From 1ecc377b1ecef7cbb1e99870d1ee3176707c104b Mon Sep 17 00:00:00 2001
From: Henri Sara <hesara@vaadin.com>
Date: Mon, 9 Nov 2015 15:00:50 +0200
Subject: [PATCH] Remove UIDL references in VFilterSelect (#19929)

Change-Id: Ia6af50fac9ff4e8945ec16272c7a3227b2600cc6
---
 .../com/vaadin/client/ui/VFilterSelect.java   | 31 ++++++++++---------
 .../client/ui/combobox/ComboBoxConnector.java | 13 ++++++--
 2 files changed, 27 insertions(+), 17 deletions(-)

diff --git a/client/src/main/java/com/vaadin/client/ui/VFilterSelect.java b/client/src/main/java/com/vaadin/client/ui/VFilterSelect.java
index a0a1e945b8..3682308e0f 100644
--- a/client/src/main/java/com/vaadin/client/ui/VFilterSelect.java
+++ b/client/src/main/java/com/vaadin/client/ui/VFilterSelect.java
@@ -70,7 +70,6 @@ import com.vaadin.client.BrowserInfo;
 import com.vaadin.client.ComputedStyle;
 import com.vaadin.client.DeferredWorker;
 import com.vaadin.client.Focusable;
-import com.vaadin.client.UIDL;
 import com.vaadin.client.VConsole;
 import com.vaadin.client.WidgetUtil;
 import com.vaadin.client.ui.aria.AriaHelper;
@@ -110,17 +109,22 @@ public class VFilterSelect extends Composite implements Field, KeyDownHandler,
         /**
          * Constructor
          * 
-         * @param uidl
-         *            The UIDL recieved from the server
+         * @param key
+         *            item key, empty string for a special null item not in
+         *            container
+         * @param caption
+         *            item caption
+         * @param style
+         *            item style name, can be empty string
+         * @param untranslatedIconUri
+         *            icon URI or null
          */
-        public FilterSelectSuggestion(UIDL uidl) {
-            key = uidl.getStringAttribute("key");
-            caption = uidl.getStringAttribute("caption");
-            style = uidl.getStringAttribute("style");
-
-            if (uidl.hasAttribute("icon")) {
-                untranslatedIconUri = uidl.getStringAttribute("icon");
-            }
+        public FilterSelectSuggestion(String key, String caption, String style,
+                String untranslatedIconUri) {
+            this.key = key;
+            this.caption = caption;
+            this.style = style;
+            this.untranslatedIconUri = untranslatedIconUri;
         }
 
         /**
@@ -994,13 +998,10 @@ public class VFilterSelect extends Composite implements Field, KeyDownHandler,
         /**
          * Updates style names in suggestion popup to help theme building.
          * 
-         * @param uidl
-         *            UIDL for the whole combo box
          * @param componentState
          *            shared state of the combo box
          */
-        public void updateStyleNames(UIDL uidl,
-                AbstractComponentState componentState) {
+        public void updateStyleNames(AbstractComponentState componentState) {
             debug("VFS.SP: updateStyleNames()");
             setStyleName(VFilterSelect.this.getStylePrimaryName()
                     + "-suggestpopup");
diff --git a/client/src/main/java/com/vaadin/client/ui/combobox/ComboBoxConnector.java b/client/src/main/java/com/vaadin/client/ui/combobox/ComboBoxConnector.java
index a7082048ca..61e5cd462e 100644
--- a/client/src/main/java/com/vaadin/client/ui/combobox/ComboBoxConnector.java
+++ b/client/src/main/java/com/vaadin/client/ui/combobox/ComboBoxConnector.java
@@ -115,7 +115,7 @@ public class ComboBoxConnector extends AbstractFieldConnector implements
             getWidget().suggestionPopupWidth = null;
         }
 
-        getWidget().suggestionPopup.updateStyleNames(uidl, getState());
+        getWidget().suggestionPopup.updateStyleNames(getState());
 
         getWidget().allowNewItem = uidl.hasAttribute("allownewitem");
         getWidget().lastNewItemString = null;
@@ -131,8 +131,17 @@ public class ComboBoxConnector extends AbstractFieldConnector implements
 
         for (final Iterator<?> i = options.getChildIterator(); i.hasNext();) {
             final UIDL optionUidl = (UIDL) i.next();
+            String key = optionUidl.getStringAttribute("key");
+            String caption = optionUidl.getStringAttribute("caption");
+            String style = optionUidl.getStringAttribute("style");
+
+            String untranslatedIconUri = null;
+            if (optionUidl.hasAttribute("icon")) {
+                untranslatedIconUri = optionUidl.getStringAttribute("icon");
+            }
+
             final FilterSelectSuggestion suggestion = getWidget().new FilterSelectSuggestion(
-                    optionUidl);
+                    key, caption, style, untranslatedIconUri);
             newSuggestions.add(suggestion);
         }
 
-- 
2.39.5