From 20b8f11c7d08b49c21519509d45c4ee1492f91bf Mon Sep 17 00:00:00 2001
From: Stas Vilchik <vilchiks@gmail.com>
Date: Wed, 13 Jul 2016 15:03:09 +0200
Subject: [PATCH] increase visibility of deprecated rules on profiles page

---
 .../js/apps/quality-profiles/home/EvolutionDeprecated.js | 6 +++++-
 .../js/apps/quality-profiles/home/ProfilesListRow.js     | 2 +-
 .../src/main/js/apps/quality-profiles/styles.css         | 7 ++++++-
 server/sonar-web/src/main/less/components/badges.less    | 9 +++++++++
 4 files changed, 21 insertions(+), 3 deletions(-)

diff --git a/server/sonar-web/src/main/js/apps/quality-profiles/home/EvolutionDeprecated.js b/server/sonar-web/src/main/js/apps/quality-profiles/home/EvolutionDeprecated.js
index 132aa9eef92..6d26699393a 100644
--- a/server/sonar-web/src/main/js/apps/quality-profiles/home/EvolutionDeprecated.js
+++ b/server/sonar-web/src/main/js/apps/quality-profiles/home/EvolutionDeprecated.js
@@ -18,6 +18,7 @@
  * Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA.
  */
 import React from 'react';
+import sortBy from 'lodash/sortBy';
 import ProfileLink from '../components/ProfileLink';
 import { getDeprecatedActiveRulesUrl } from '../../../helpers/urls';
 import { ProfilesListType } from '../propTypes';
@@ -40,6 +41,9 @@ export default class EvolutionDeprecated extends React.Component {
         .map(p => p.activeDeprecatedRuleCount)
         .reduce((p, c) => p + c, 0);
 
+    const sortedProfiles =
+        sortBy(profilesWithDeprecations, p => -p.activeDeprecatedRuleCount);
+
     return (
         <div
             className="quality-profile-box quality-profiles-evolution-deprecated">
@@ -54,7 +58,7 @@ export default class EvolutionDeprecated extends React.Component {
             )}
           </div>
           <ul>
-            {profilesWithDeprecations.map(profile => (
+            {sortedProfiles.map(profile => (
                 <li key={profile.key} className="spacer-top">
                   <div className="text-ellipsis">
                     <ProfileLink
diff --git a/server/sonar-web/src/main/js/apps/quality-profiles/home/ProfilesListRow.js b/server/sonar-web/src/main/js/apps/quality-profiles/home/ProfilesListRow.js
index 2ff6c99936c..fe65cbcce23 100644
--- a/server/sonar-web/src/main/js/apps/quality-profiles/home/ProfilesListRow.js
+++ b/server/sonar-web/src/main/js/apps/quality-profiles/home/ProfilesListRow.js
@@ -86,7 +86,7 @@ export default class ProfilesListRow extends React.Component {
         <div>
           {profile.activeDeprecatedRuleCount > 0 && (
               <span className="spacer-right">
-                <a className="badge badge-focus"
+                <a className="badge badge-danger-light"
                    href={deprecatedRulesUrl}
                    title={translate('quality_profiles.deprecated_rules')}
                    data-toggle="tooltip">
diff --git a/server/sonar-web/src/main/js/apps/quality-profiles/styles.css b/server/sonar-web/src/main/js/apps/quality-profiles/styles.css
index 0c1a947cfac..5d97a57c524 100644
--- a/server/sonar-web/src/main/js/apps/quality-profiles/styles.css
+++ b/server/sonar-web/src/main/js/apps/quality-profiles/styles.css
@@ -111,7 +111,12 @@
   padding-top: 55px;
 }
 
-.quality-profiles-evolution-deprecated,
+.quality-profiles-evolution-deprecated {
+  margin-bottom: 20px;
+  border-color: #ebccd1;
+  background-color: #f2dede;
+}
+
 .quality-profiles-evolution-stagnant {
   margin-bottom: 20px;
   border-color: #faebcc;
diff --git a/server/sonar-web/src/main/less/components/badges.less b/server/sonar-web/src/main/less/components/badges.less
index e130b6a6c04..1d0b557f708 100644
--- a/server/sonar-web/src/main/less/components/badges.less
+++ b/server/sonar-web/src/main/less/components/badges.less
@@ -75,6 +75,15 @@
   background-color: @red
 }
 
+.badge-danger-light {
+  border: 1px solid #ebccd1 !important;
+  border-radius: 3px;
+  background-color: #f2dede;
+  color: #a94442;
+
+  a&:hover, a&:focus, a&:active { color: #a94442; }
+}
+
 .badge-focus {
   border: 1px solid #faebcc;
   border-radius: 3px;
-- 
2.39.5