From 226ff67a002cacb89ffc1bf9c3760eec17b558a9 Mon Sep 17 00:00:00 2001 From: =?utf8?q?Scott=20Gonz=C3=A1lez?= Date: Mon, 13 Jul 2009 00:51:03 +0000 Subject: [PATCH] animateClass: Don't animate scrollbar properties. Fixes #4676 - toggleClass breaks in IE sometimes. --- ui/effects.core.js | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/ui/effects.core.js b/ui/effects.core.js index 593ee6586..2cc7542f2 100644 --- a/ui/effects.core.js +++ b/ui/effects.core.js @@ -113,6 +113,7 @@ $.effects = { for(var n in newStyle) { if( typeof newStyle[n] != "function" && newStyle[n] /* No functions and null properties */ && n.indexOf("Moz") == -1 && n.indexOf("length") == -1 /* No mozilla spezific render properties. */ + && n.indexOf("scrollbar") == -1 /* No scrollbar properties - causes problems in IE */ && newStyle[n] != oldStyle[n] /* Only values that have changed are used for the animation */ && (n.match(/color/i) || (!n.match(/color/i) && !isNaN(parseInt(newStyle[n],10)))) /* Only things that can be parsed to integers or colors */ && (oldStyle.position != "static" || (oldStyle.position == "static" && !n.match(/left|top|bottom|right/))) /* No need for positions when dealing with static positions */ @@ -133,6 +134,12 @@ $.effects = { function _normalizeArguments(effect, options, speed, callback) { // shift params for method overloading + if (typeof effect == 'object') { + callback = options; + speed = null; + options = effect; + effect = options.effect; + } if ($.isFunction(options)) { callback = options; speed = null; -- 2.39.5