From 23d0e14babe89fff39e377c8ea7295837b07a343 Mon Sep 17 00:00:00 2001 From: James Moger Date: Thu, 17 Apr 2014 20:31:41 -0400 Subject: [PATCH] [findbugs] Fix missing 'throw' on plugin installation failure --- .../com/gitblit/transport/ssh/commands/PluginDispatcher.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/main/java/com/gitblit/transport/ssh/commands/PluginDispatcher.java b/src/main/java/com/gitblit/transport/ssh/commands/PluginDispatcher.java index 62b13576..6f8f95ae 100644 --- a/src/main/java/com/gitblit/transport/ssh/commands/PluginDispatcher.java +++ b/src/main/java/com/gitblit/transport/ssh/commands/PluginDispatcher.java @@ -518,7 +518,7 @@ public class PluginDispatcher extends DispatchCommand { if (gitblit.installPlugin(urlOrId, !disableChecksum)) { stdout.println(String.format("Installed %s", urlOrId)); } else { - new UnloggedFailure(1, String.format("Failed to install %s", urlOrId)); + throw new UnloggedFailure(1, String.format("Failed to install %s", urlOrId)); } } else { PluginRelease pr = gitblit.lookupRelease(urlOrId, version); -- 2.39.5