From 25eb865e2f40c8e318c8123eba23d2672d6f5349 Mon Sep 17 00:00:00 2001 From: Julien Lancelot Date: Fri, 18 Jan 2019 15:33:14 +0100 Subject: [PATCH] Fix quality flaws --- .../org/sonar/server/measure/ws/MeasureDtoToWsMeasure.java | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/server/sonar-server/src/main/java/org/sonar/server/measure/ws/MeasureDtoToWsMeasure.java b/server/sonar-server/src/main/java/org/sonar/server/measure/ws/MeasureDtoToWsMeasure.java index 9509da98648..ad9929aeb7a 100644 --- a/server/sonar-server/src/main/java/org/sonar/server/measure/ws/MeasureDtoToWsMeasure.java +++ b/server/sonar-server/src/main/java/org/sonar/server/measure/ws/MeasureDtoToWsMeasure.java @@ -26,6 +26,7 @@ import org.sonar.db.metric.MetricDto; import org.sonarqube.ws.Measures; import org.sonarqube.ws.Measures.Measure; +import static java.lang.Double.compare; import static java.util.Optional.ofNullable; import static org.sonar.server.measure.ws.MeasureValueFormatter.formatMeasureValue; import static org.sonar.server.measure.ws.MeasureValueFormatter.formatNumericalValue; @@ -54,7 +55,7 @@ class MeasureDtoToWsMeasure { // a measure value can be null, new_violations metric for example if (!Double.isNaN(doubleValue) || stringValue != null) { measureBuilder.setValue(formatMeasureValue(doubleValue, stringValue, metric)); - ofNullable(bestValue).ifPresent(v -> measureBuilder.setBestValue(doubleValue == v)); + ofNullable(bestValue).ifPresent(v -> measureBuilder.setBestValue(compare(doubleValue, v) == 0)); } Measures.PeriodValue.Builder periodBuilder = Measures.PeriodValue.newBuilder(); @@ -65,7 +66,7 @@ class MeasureDtoToWsMeasure { .clear() .setIndex(1) .setValue(formatNumericalValue(variation, metric)); - ofNullable(bestValue).ifPresent(v -> builderForValue.setBestValue(variation == v)); + ofNullable(bestValue).ifPresent(v -> builderForValue.setBestValue(compare(variation, v) == 0)); measureBuilder.getPeriodsBuilder().addPeriodsValue(builderForValue); } } -- 2.39.5