From 26c5d0e56a8c5adb2c93cda45e25175363798516 Mon Sep 17 00:00:00 2001 From: Jonathan Nieder Date: Sat, 4 Aug 2018 14:00:26 -0700 Subject: [PATCH] RebaseCommand: Remove unnecessary fall through comments It's easier to read a list of cases case A: case B: case C: ... do something ...; break; without intervening "// fall through" lines separating the cases. This also makes it clearer that JGit uses "$FALL-THROUGH$", not "fall through", to suppress fallthrough warnings in switch statements. Eclipse does not pay attention to the second comment style. Change-Id: I5279a727aee2868854d06bfcaac8cb8186b4299e Signed-off-by: Jonathan Nieder --- org.eclipse.jgit/src/org/eclipse/jgit/api/RebaseCommand.java | 2 -- 1 file changed, 2 deletions(-) diff --git a/org.eclipse.jgit/src/org/eclipse/jgit/api/RebaseCommand.java b/org.eclipse.jgit/src/org/eclipse/jgit/api/RebaseCommand.java index 98c16b8931..1783c4193e 100644 --- a/org.eclipse.jgit/src/org/eclipse/jgit/api/RebaseCommand.java +++ b/org.eclipse.jgit/src/org/eclipse/jgit/api/RebaseCommand.java @@ -275,9 +275,7 @@ public class RebaseCommand extends GitCommand { throw new JGitInternalException(ioe.getMessage(), ioe); } case PROCESS_STEPS: - // fall through case SKIP: - // fall through case CONTINUE: String upstreamCommitId = rebaseState.readFile(ONTO); try { -- 2.39.5