From 275d353f59074f78cfec5786e5989637a5606834 Mon Sep 17 00:00:00 2001 From: Florian Zschocke Date: Sat, 4 Apr 2020 21:34:30 +0200 Subject: [PATCH] =?utf8?q?=F0=9F=8F=83run:=20Use=20quotes=20around=20class?= =?utf8?q?=20path=20in=20scripts?= MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit While most systems will not need the class path passed to the JVM with the `-cp` parameter to be in quotes, apparently some exist where that will not work without the quotes, e.g. FreeBSD. So always use quotes for the class path in all scripts. Issue #1333 --- src/main/distrib/linux/authority.sh | 2 +- src/main/distrib/linux/migrate-tickets.sh | 2 +- src/main/distrib/linux/reindex-tickets.sh | 2 +- src/site/federation.mkd | 2 +- src/site/setup_go.mkd | 2 +- 5 files changed, 5 insertions(+), 5 deletions(-) diff --git a/src/main/distrib/linux/authority.sh b/src/main/distrib/linux/authority.sh index 740f51a8..c5c6c687 100644 --- a/src/main/distrib/linux/authority.sh +++ b/src/main/distrib/linux/authority.sh @@ -1,2 +1,2 @@ #!/bin/bash -java -cp gitblit.jar:ext/* com.gitblit.authority.GitblitAuthority --baseFolder data +java -cp "gitblit.jar:ext/*" com.gitblit.authority.GitblitAuthority --baseFolder data diff --git a/src/main/distrib/linux/migrate-tickets.sh b/src/main/distrib/linux/migrate-tickets.sh index ce746bf9..4f360918 100644 --- a/src/main/distrib/linux/migrate-tickets.sh +++ b/src/main/distrib/linux/migrate-tickets.sh @@ -17,5 +17,5 @@ if [ -z $1 ] || [ -z $2 ]; then exit 1; fi -java -cp gitblit.jar:./ext/* com.gitblit.MigrateTickets $1 --baseFolder $2 +java -cp "gitblit.jar:ext/*" com.gitblit.MigrateTickets $1 --baseFolder $2 diff --git a/src/main/distrib/linux/reindex-tickets.sh b/src/main/distrib/linux/reindex-tickets.sh index 6985d606..42239ea1 100644 --- a/src/main/distrib/linux/reindex-tickets.sh +++ b/src/main/distrib/linux/reindex-tickets.sh @@ -20,5 +20,5 @@ if [ -z $1 ] ; then exit 1; fi -java -cp gitblit.jar:./ext/* com.gitblit.ReindexTickets --baseFolder $1 +java -cp "gitblit.jar:ext/*" com.gitblit.ReindexTickets --baseFolder $1 diff --git a/src/site/federation.mkd b/src/site/federation.mkd index 231a9f35..b802a087 100644 --- a/src/site/federation.mkd +++ b/src/site/federation.mkd @@ -335,6 +335,6 @@ Instead of using `federation.properties` you may directly specify a Gitblit inst java -cp fedclient.jar;"%CD%/ext/*" com.gitblit.FederationClient --url https://go.gitblit.com --mirror --bare --token 123456789 --repositoriesFolder c:/mymirror - java -cp fedclient.jar:ext/* com.gitblit.FederationClient --url https://go.gitblit.com --mirror --bare --token 123456789 + java -cp "fedclient.jar:ext/*" com.gitblit.FederationClient --url https://go.gitblit.com --mirror --bare --token 123456789 --repositoriesFolder /srv/mymirror --daemon --frequency "24 hours" diff --git a/src/site/setup_go.mkd b/src/site/setup_go.mkd index 20b4ba48..e0470f31 100644 --- a/src/site/setup_go.mkd +++ b/src/site/setup_go.mkd @@ -17,7 +17,7 @@ Open `data/gitblit.properties` in your favorite text editor and make sure to rev **NOTE:** You can only have **one** SSL certificate specified for a port. 4. exit the authority app 4. Windows: Execute `gitblit.cmd` or `java -cp gitblit.jar;"%CD%\ext\*" com.gitblit.GitBlitServer --baseFolder data` from a command-line - Linux/OSX: Execute `gitblit.sh` or `java -cp gitblit.jar;ext/* com.gitblit.GitBlitServer --baseFolder data` from a command-line + Linux/OSX: Execute `gitblit.sh` or `java -cp "gitblit.jar:ext/*"" com.gitblit.GitBlitServer --baseFolder data` from a command-line 5. Open your browser to or depending on your chosen configuration. 6. Enter the default administrator credentials: **admin / admin** and click the *Login* button **NOTE:** Make sure to change the administrator username and/or password!! -- 2.39.5