From 27f26bd9bc673c69e074cda4eacd2ef6245dc94f Mon Sep 17 00:00:00 2001
From: Wouter Admiraal <wouter.admiraal@sonarsource.com>
Date: Tue, 13 Jun 2023 13:36:50 +0200
Subject: [PATCH] SONAR-19524 Don't render h1 as a child of h2

---
 .../src/main/js/apps/overview/branches/ActivityPanel.tsx    | 2 +-
 .../src/main/js/apps/overview/branches/MeasuresPanel.tsx    | 6 +++---
 .../js/apps/overview/components/QualityGateStatusTitle.tsx  | 6 +++---
 .../js/apps/overview/pullRequests/PullRequestOverview.tsx   | 6 +++---
 4 files changed, 10 insertions(+), 10 deletions(-)

diff --git a/server/sonar-web/src/main/js/apps/overview/branches/ActivityPanel.tsx b/server/sonar-web/src/main/js/apps/overview/branches/ActivityPanel.tsx
index 2473714bff1..47ede69bd92 100644
--- a/server/sonar-web/src/main/js/apps/overview/branches/ActivityPanel.tsx
+++ b/server/sonar-web/src/main/js/apps/overview/branches/ActivityPanel.tsx
@@ -92,7 +92,7 @@ export function ActivityPanel(props: ActivityPanelProps) {
 
   return (
     <div className="sw-mt-8">
-      <PageTitle text={translate('overview.activity')} />
+      <PageTitle as="h2" text={translate('overview.activity')} />
       <Card className="overview-panel sw-mt-4" data-test="overview__activity-panel">
         <GraphsHeader graph={graph} metrics={metrics} onUpdateGraph={props.onGraphChange} />
         <GraphsHistory
diff --git a/server/sonar-web/src/main/js/apps/overview/branches/MeasuresPanel.tsx b/server/sonar-web/src/main/js/apps/overview/branches/MeasuresPanel.tsx
index 1cbfcaafef2..f8b0e30662d 100644
--- a/server/sonar-web/src/main/js/apps/overview/branches/MeasuresPanel.tsx
+++ b/server/sonar-web/src/main/js/apps/overview/branches/MeasuresPanel.tsx
@@ -119,9 +119,9 @@ export function MeasuresPanel(props: MeasuresPanelProps) {
       <div className="sw-float-right -sw-mt-6">
         <ComponentReportActions component={component} branch={branch} />
       </div>
-      <h2 className="sw-flex sw-mb-4">
-        <PageTitle text={translate('overview.measures')} />
-      </h2>
+      <div className="sw-flex sw-mb-4">
+        <PageTitle as="h2" text={translate('overview.measures')} />
+      </div>
 
       {loading ? (
         <div>
diff --git a/server/sonar-web/src/main/js/apps/overview/components/QualityGateStatusTitle.tsx b/server/sonar-web/src/main/js/apps/overview/components/QualityGateStatusTitle.tsx
index c5078fe5e4d..9f31a4298ad 100644
--- a/server/sonar-web/src/main/js/apps/overview/components/QualityGateStatusTitle.tsx
+++ b/server/sonar-web/src/main/js/apps/overview/components/QualityGateStatusTitle.tsx
@@ -26,15 +26,15 @@ import { translate } from '../../../helpers/l10n';
 export function QualityGateStatusTitle() {
   return (
     <div className="sw-flex sw-items-center sw-mb-4">
-      <h2 className="sw-flex sw-items-center">
-        <PageTitle text={translate('overview.quality_gate.status')} />
+      <div className="sw-flex sw-items-center">
+        <PageTitle as="h2" text={translate('overview.quality_gate.status')} />
         <HelpTooltip
           className="sw-ml-2"
           overlay={<div className="sw-my-4">{translate('overview.quality_gate.help')}</div>}
         >
           <HelperHintIcon aria-label="help-tooltip" />
         </HelpTooltip>
-      </h2>
+      </div>
     </div>
   );
 }
diff --git a/server/sonar-web/src/main/js/apps/overview/pullRequests/PullRequestOverview.tsx b/server/sonar-web/src/main/js/apps/overview/pullRequests/PullRequestOverview.tsx
index 5a249bbd76a..7bb2f167366 100644
--- a/server/sonar-web/src/main/js/apps/overview/pullRequests/PullRequestOverview.tsx
+++ b/server/sonar-web/src/main/js/apps/overview/pullRequests/PullRequestOverview.tsx
@@ -231,9 +231,9 @@ export class PullRequestOverview extends React.PureComponent<Props, State> {
             </div>
 
             <div className="sw-flex-1">
-              <h2 className="sw-body-md-highlight">
-                <PageTitle text={translate('overview.measures')} />
-              </h2>
+              <div className="sw-body-md-highlight">
+                <PageTitle as="h2" text={translate('overview.measures')} />
+              </div>
 
               <div className="sw-grid sw-grid-cols-2 sw-gap-4 sw-mt-4">
                 {[
-- 
2.39.5