From 296c5b86f39c43513ec111afc728a8b2926309c5 Mon Sep 17 00:00:00 2001
From: Stas Vilchik <vilchiks@gmail.com>
Date: Wed, 12 Mar 2014 11:51:14 +0600
Subject: [PATCH] SONAR-5007 Temporary remove facets (until SONAR-5012)

---
 .../templates/_coding_rules_layout.hbs.erb    |  1 -
 .../javascripts/coding-rules/app.coffee       | 21 ++--------
 .../webapp/javascripts/coding-rules/app.js    | 36 ++++-------------
 .../javascripts/coding-rules/layout.coffee    |  1 -
 .../webapp/javascripts/coding-rules/layout.js |  3 +-
 .../javascripts/coding-rules/mockjax.coffee   |  5 ---
 .../javascripts/coding-rules/mockjax.js       | 14 +------
 .../coding-rules-facets-item-view.coffee      | 11 -----
 .../views/coding-rules-facets-item-view.js    | 27 -------------
 .../views/coding-rules-facets-view.coffee     | 25 ------------
 .../views/coding-rules-facets-view.js         | 40 -------------------
 .../main/webapp/stylesheets/coding-rules.css  |  7 ----
 .../main/webapp/stylesheets/coding-rules.less | 10 -----
 13 files changed, 13 insertions(+), 188 deletions(-)
 delete mode 100644 sonar-server/src/main/webapp/javascripts/coding-rules/views/coding-rules-facets-item-view.coffee
 delete mode 100644 sonar-server/src/main/webapp/javascripts/coding-rules/views/coding-rules-facets-item-view.js
 delete mode 100644 sonar-server/src/main/webapp/javascripts/coding-rules/views/coding-rules-facets-view.coffee
 delete mode 100644 sonar-server/src/main/webapp/javascripts/coding-rules/views/coding-rules-facets-view.js

diff --git a/sonar-server/src/main/webapp/WEB-INF/app/views/coding_rules/templates/_coding_rules_layout.hbs.erb b/sonar-server/src/main/webapp/WEB-INF/app/views/coding_rules/templates/_coding_rules_layout.hbs.erb
index 90f4a0ee773..debdccc91f1 100644
--- a/sonar-server/src/main/webapp/WEB-INF/app/views/coding_rules/templates/_coding_rules_layout.hbs.erb
+++ b/sonar-server/src/main/webapp/WEB-INF/app/views/coding_rules/templates/_coding_rules_layout.hbs.erb
@@ -1,7 +1,6 @@
 <script id="coding-rules-layout" type="text/x-handlebars-template">
   <div class="navigator-header"></div>
   <div class="navigator-filters"></div>
-  <div class="navigator-facets"></div>
   <div class="navigator-actions"></div>
   <div class="navigator-results"></div>
   <div class="navigator-details"></div>
diff --git a/sonar-server/src/main/webapp/javascripts/coding-rules/app.coffee b/sonar-server/src/main/webapp/javascripts/coding-rules/app.coffee
index 2ac34dbf197..ec4caa0b769 100644
--- a/sonar-server/src/main/webapp/javascripts/coding-rules/app.coffee
+++ b/sonar-server/src/main/webapp/javascripts/coding-rules/app.coffee
@@ -28,7 +28,6 @@ requirejs [
   'coding-rules/views/actions-view',
   'coding-rules/views/filter-bar-view',
   'coding-rules/views/coding-rules-list-view',
-  'coding-rules/views/coding-rules-facets-view',
 
   # filters
   'navigator/filters/base-filters',
@@ -48,7 +47,6 @@ requirejs [
   CodingRulesActionsView,
   CodingRulesFilterBarView,
   CodingRulesListView,
-  CodingRulesFacetsView,
 
   # filters
   BaseFilters,
@@ -96,7 +94,7 @@ requirejs [
 
 
 
-  App.fetchList = (firstPage, fetchFacets = true) ->
+  App.fetchList = (firstPage) ->
     query = @getQuery()
     fetchQuery = _.extend { pageIndex: @pageIndex }, query
 
@@ -105,13 +103,10 @@ requirejs [
           sort: @codingRules.sorting.sort,
           asc: @codingRules.sorting.asc
 
-    unless fetchFacets
-      _.extend fetchQuery, facets: false
-
     @storeQuery query, @codingRules.sorting
 
     @layout.showSpinner 'resultsRegion'
-    @layout.showSpinner 'facetsRegion' if fetchFacets
+    @layout.showSpinner 'facetsRegion'
     jQuery.ajax
       url: "#{baseUrl}/api/codingrules/search"
       data: fetchQuery
@@ -127,18 +122,11 @@ requirejs [
       @layout.resultsRegion.show @codingRulesListView
       @codingRulesListView.selectFirst()
 
-      if fetchFacets
-        @facets.reset r.facets
-        @codingRulesFacetsView = new CodingRulesFacetsView
-          app: @
-          collection: @facets
-        @layout.facetsRegion.show @codingRulesFacetsView
-
 
 
-  App.fetchFirstPage = (fetchFacets = true) ->
+  App.fetchFirstPage = ->
     @pageIndex = 1
-    App.fetchList true, fetchFacets
+    App.fetchList true
 
 
   App.fetchNextPage = ->
@@ -167,7 +155,6 @@ requirejs [
   # Define coding rules
   App.addInitializer ->
     @codingRules = new Backbone.Collection
-    @facets = new Backbone.Collection
 
 
   # Construct status bar
diff --git a/sonar-server/src/main/webapp/javascripts/coding-rules/app.js b/sonar-server/src/main/webapp/javascripts/coding-rules/app.js
index 2b238827ade..bb0e902cf2b 100644
--- a/sonar-server/src/main/webapp/javascripts/coding-rules/app.js
+++ b/sonar-server/src/main/webapp/javascripts/coding-rules/app.js
@@ -22,7 +22,7 @@
     }
   });
 
-  requirejs(['backbone', 'backbone.marionette', 'coding-rules/layout', 'coding-rules/router', 'coding-rules/views/header-view', 'coding-rules/views/actions-view', 'coding-rules/views/filter-bar-view', 'coding-rules/views/coding-rules-list-view', 'coding-rules/views/coding-rules-facets-view', 'navigator/filters/base-filters', 'navigator/filters/choice-filters', 'navigator/filters/string-filters', 'coding-rules/views/filters/quality-profile-filter-view', 'coding-rules/mockjax'], function(Backbone, Marionette, CodingRulesLayout, CodingRulesRouter, CodingRulesHeaderView, CodingRulesActionsView, CodingRulesFilterBarView, CodingRulesListView, CodingRulesFacetsView, BaseFilters, ChoiceFilters, StringFilterView, QualityProfileFilterView) {
+  requirejs(['backbone', 'backbone.marionette', 'coding-rules/layout', 'coding-rules/router', 'coding-rules/views/header-view', 'coding-rules/views/actions-view', 'coding-rules/views/filter-bar-view', 'coding-rules/views/coding-rules-list-view', 'navigator/filters/base-filters', 'navigator/filters/choice-filters', 'navigator/filters/string-filters', 'coding-rules/views/filters/quality-profile-filter-view', 'coding-rules/mockjax'], function(Backbone, Marionette, CodingRulesLayout, CodingRulesRouter, CodingRulesHeaderView, CodingRulesActionsView, CodingRulesFilterBarView, CodingRulesListView, BaseFilters, ChoiceFilters, StringFilterView, QualityProfileFilterView) {
     var App, appXHR;
     jQuery.ajaxSetup({
       error: function(jqXHR) {
@@ -60,12 +60,9 @@
         replace: true
       });
     };
-    App.fetchList = function(firstPage, fetchFacets) {
+    App.fetchList = function(firstPage) {
       var fetchQuery, query,
         _this = this;
-      if (fetchFacets == null) {
-        fetchFacets = true;
-      }
       query = this.getQuery();
       fetchQuery = _.extend({
         pageIndex: this.pageIndex
@@ -76,16 +73,9 @@
           asc: this.codingRules.sorting.asc
         });
       }
-      if (!fetchFacets) {
-        _.extend(fetchQuery, {
-          facets: false
-        });
-      }
       this.storeQuery(query, this.codingRules.sorting);
       this.layout.showSpinner('resultsRegion');
-      if (fetchFacets) {
-        this.layout.showSpinner('facetsRegion');
-      }
+      this.layout.showSpinner('facetsRegion');
       return jQuery.ajax({
         url: "" + baseUrl + "/api/codingrules/search",
         data: fetchQuery
@@ -101,23 +91,12 @@
           collection: _this.codingRules
         });
         _this.layout.resultsRegion.show(_this.codingRulesListView);
-        _this.codingRulesListView.selectFirst();
-        if (fetchFacets) {
-          _this.facets.reset(r.facets);
-          _this.codingRulesFacetsView = new CodingRulesFacetsView({
-            app: _this,
-            collection: _this.facets
-          });
-          return _this.layout.facetsRegion.show(_this.codingRulesFacetsView);
-        }
+        return _this.codingRulesListView.selectFirst();
       });
     };
-    App.fetchFirstPage = function(fetchFacets) {
-      if (fetchFacets == null) {
-        fetchFacets = true;
-      }
+    App.fetchFirstPage = function() {
       this.pageIndex = 1;
-      return App.fetchList(true, fetchFacets);
+      return App.fetchList(true);
     };
     App.fetchNextPage = function() {
       if (this.pageIndex < this.codingRules.paging.pages) {
@@ -147,8 +126,7 @@
       return this.layout.headerRegion.show(this.codingRulesHeaderView);
     });
     App.addInitializer(function() {
-      this.codingRules = new Backbone.Collection;
-      return this.facets = new Backbone.Collection;
+      return this.codingRules = new Backbone.Collection;
     });
     App.addInitializer(function() {
       this.codingRulesActionsView = new CodingRulesActionsView({
diff --git a/sonar-server/src/main/webapp/javascripts/coding-rules/layout.coffee b/sonar-server/src/main/webapp/javascripts/coding-rules/layout.coffee
index 9f2c5dd7ecf..0e3abd4cfd2 100644
--- a/sonar-server/src/main/webapp/javascripts/coding-rules/layout.coffee
+++ b/sonar-server/src/main/webapp/javascripts/coding-rules/layout.coffee
@@ -17,7 +17,6 @@ define [
       resultsRegion: '.navigator-results'
       detailsRegion: '.navigator-details'
       filtersRegion: '.navigator-filters'
-      facetsRegion: '.navigator-facets'
 
 
     onRender: ->
diff --git a/sonar-server/src/main/webapp/javascripts/coding-rules/layout.js b/sonar-server/src/main/webapp/javascripts/coding-rules/layout.js
index 2a2f75f1663..91d7c1067ee 100644
--- a/sonar-server/src/main/webapp/javascripts/coding-rules/layout.js
+++ b/sonar-server/src/main/webapp/javascripts/coding-rules/layout.js
@@ -24,8 +24,7 @@
         actionsRegion: '.navigator-actions',
         resultsRegion: '.navigator-results',
         detailsRegion: '.navigator-details',
-        filtersRegion: '.navigator-filters',
-        facetsRegion: '.navigator-facets'
+        filtersRegion: '.navigator-filters'
       };
 
       AppLayout.prototype.onRender = function() {
diff --git a/sonar-server/src/main/webapp/javascripts/coding-rules/mockjax.coffee b/sonar-server/src/main/webapp/javascripts/coding-rules/mockjax.coffee
index 80b4092174a..1423e37bdb0 100644
--- a/sonar-server/src/main/webapp/javascripts/coding-rules/mockjax.coffee
+++ b/sonar-server/src/main/webapp/javascripts/coding-rules/mockjax.coffee
@@ -76,11 +76,6 @@ define ['jquery.mockjax'], ->
       paging:
         total: 5
         fTotal: '5'
-      facets: [
-        { name: 'Language', options: ['Java', 'JavaScript'] }
-        { name: 'Repository', options: ['PMD', 'PMD Unit Tests', 'Checkstyle'] }
-        { name: 'Tags', options: ['brain-overload', 'bug', 'comment', 'convention', 'error-handling', 'formatting', 'java8'] }
-      ]
 
 
 
diff --git a/sonar-server/src/main/webapp/javascripts/coding-rules/mockjax.js b/sonar-server/src/main/webapp/javascripts/coding-rules/mockjax.js
index e8a5a7d9760..ad63ef15be6 100644
--- a/sonar-server/src/main/webapp/javascripts/coding-rules/mockjax.js
+++ b/sonar-server/src/main/webapp/javascripts/coding-rules/mockjax.js
@@ -75,19 +75,7 @@
         paging: {
           total: 5,
           fTotal: '5'
-        },
-        facets: [
-          {
-            name: 'Language',
-            options: ['Java', 'JavaScript']
-          }, {
-            name: 'Repository',
-            options: ['PMD', 'PMD Unit Tests', 'Checkstyle']
-          }, {
-            name: 'Tags',
-            options: ['brain-overload', 'bug', 'comment', 'convention', 'error-handling', 'formatting', 'java8']
-          }
-        ]
+        }
       })
     });
     jQuery.mockjax({
diff --git a/sonar-server/src/main/webapp/javascripts/coding-rules/views/coding-rules-facets-item-view.coffee b/sonar-server/src/main/webapp/javascripts/coding-rules/views/coding-rules-facets-item-view.coffee
deleted file mode 100644
index 1232a3d66e2..00000000000
--- a/sonar-server/src/main/webapp/javascripts/coding-rules/views/coding-rules-facets-item-view.coffee
+++ /dev/null
@@ -1,11 +0,0 @@
-define [
-  'backbone.marionette',
-  'common/handlebars-extensions'
-], (
-  Marionette,
-) ->
-
-  class CodingRulesFacetsView extends Marionette.ItemView
-    tagName: 'li'
-    className: 'navigator-facets-list-item'
-    template: getTemplate '#coding-rules-facets-item-template'
diff --git a/sonar-server/src/main/webapp/javascripts/coding-rules/views/coding-rules-facets-item-view.js b/sonar-server/src/main/webapp/javascripts/coding-rules/views/coding-rules-facets-item-view.js
deleted file mode 100644
index 85dcc584c9d..00000000000
--- a/sonar-server/src/main/webapp/javascripts/coding-rules/views/coding-rules-facets-item-view.js
+++ /dev/null
@@ -1,27 +0,0 @@
-// Generated by CoffeeScript 1.6.3
-(function() {
-  var __hasProp = {}.hasOwnProperty,
-    __extends = function(child, parent) { for (var key in parent) { if (__hasProp.call(parent, key)) child[key] = parent[key]; } function ctor() { this.constructor = child; } ctor.prototype = parent.prototype; child.prototype = new ctor(); child.__super__ = parent.prototype; return child; };
-
-  define(['backbone.marionette', 'common/handlebars-extensions'], function(Marionette) {
-    var CodingRulesFacetsView, _ref;
-    return CodingRulesFacetsView = (function(_super) {
-      __extends(CodingRulesFacetsView, _super);
-
-      function CodingRulesFacetsView() {
-        _ref = CodingRulesFacetsView.__super__.constructor.apply(this, arguments);
-        return _ref;
-      }
-
-      CodingRulesFacetsView.prototype.tagName = 'li';
-
-      CodingRulesFacetsView.prototype.className = 'navigator-facets-list-item';
-
-      CodingRulesFacetsView.prototype.template = getTemplate('#coding-rules-facets-item-template');
-
-      return CodingRulesFacetsView;
-
-    })(Marionette.ItemView);
-  });
-
-}).call(this);
diff --git a/sonar-server/src/main/webapp/javascripts/coding-rules/views/coding-rules-facets-view.coffee b/sonar-server/src/main/webapp/javascripts/coding-rules/views/coding-rules-facets-view.coffee
deleted file mode 100644
index 0dd3b2d45e6..00000000000
--- a/sonar-server/src/main/webapp/javascripts/coding-rules/views/coding-rules-facets-view.coffee
+++ /dev/null
@@ -1,25 +0,0 @@
-define [
-  'backbone.marionette',
-  'coding-rules/views/coding-rules-facets-item-view'
-], (
-  Marionette,
-  CodingRulesFacetsItemView
-) ->
-
-  class CodingRulesFacetsView extends Marionette.CollectionView
-    tagName: 'ul'
-    className: 'navigator-facets-list'
-    itemView: CodingRulesFacetsItemView
-
-
-    ui:
-      options: '.navigator-facets-list-item-option'
-
-
-    events:
-      'click @ui.options': 'toggleOption'
-
-
-    toggleOption: (e) ->
-      jQuery(e.currentTarget).toggleClass 'active'
-      @options.app.fetchFirstPage false
diff --git a/sonar-server/src/main/webapp/javascripts/coding-rules/views/coding-rules-facets-view.js b/sonar-server/src/main/webapp/javascripts/coding-rules/views/coding-rules-facets-view.js
deleted file mode 100644
index 6e3d9064121..00000000000
--- a/sonar-server/src/main/webapp/javascripts/coding-rules/views/coding-rules-facets-view.js
+++ /dev/null
@@ -1,40 +0,0 @@
-// Generated by CoffeeScript 1.6.3
-(function() {
-  var __hasProp = {}.hasOwnProperty,
-    __extends = function(child, parent) { for (var key in parent) { if (__hasProp.call(parent, key)) child[key] = parent[key]; } function ctor() { this.constructor = child; } ctor.prototype = parent.prototype; child.prototype = new ctor(); child.__super__ = parent.prototype; return child; };
-
-  define(['backbone.marionette', 'coding-rules/views/coding-rules-facets-item-view'], function(Marionette, CodingRulesFacetsItemView) {
-    var CodingRulesFacetsView, _ref;
-    return CodingRulesFacetsView = (function(_super) {
-      __extends(CodingRulesFacetsView, _super);
-
-      function CodingRulesFacetsView() {
-        _ref = CodingRulesFacetsView.__super__.constructor.apply(this, arguments);
-        return _ref;
-      }
-
-      CodingRulesFacetsView.prototype.tagName = 'ul';
-
-      CodingRulesFacetsView.prototype.className = 'navigator-facets-list';
-
-      CodingRulesFacetsView.prototype.itemView = CodingRulesFacetsItemView;
-
-      CodingRulesFacetsView.prototype.ui = {
-        options: '.navigator-facets-list-item-option'
-      };
-
-      CodingRulesFacetsView.prototype.events = {
-        'click @ui.options': 'toggleOption'
-      };
-
-      CodingRulesFacetsView.prototype.toggleOption = function(e) {
-        jQuery(e.currentTarget).toggleClass('active');
-        return this.options.app.fetchFirstPage(false);
-      };
-
-      return CodingRulesFacetsView;
-
-    })(Marionette.CollectionView);
-  });
-
-}).call(this);
diff --git a/sonar-server/src/main/webapp/stylesheets/coding-rules.css b/sonar-server/src/main/webapp/stylesheets/coding-rules.css
index 7f9f781a642..735bca88583 100644
--- a/sonar-server/src/main/webapp/stylesheets/coding-rules.css
+++ b/sonar-server/src/main/webapp/stylesheets/coding-rules.css
@@ -13,13 +13,6 @@
 .coding-rules-page .navigator-results .spinner {
   margin: 10px;
 }
-.coding-rules-page .navigator-actions,
-.coding-rules-page .navigator-details {
-  top: 194px;
-}
-.coding-rules-page .navigator-results {
-  top: 224px;
-}
 /*
  * Detail
  */
diff --git a/sonar-server/src/main/webapp/stylesheets/coding-rules.less b/sonar-server/src/main/webapp/stylesheets/coding-rules.less
index 78ee8871a4d..26c61ba8546 100644
--- a/sonar-server/src/main/webapp/stylesheets/coding-rules.less
+++ b/sonar-server/src/main/webapp/stylesheets/coding-rules.less
@@ -9,16 +9,6 @@
     margin: @navigatorPadding;
   }
 
-  .navigator-actions,
-  .navigator-details {
-    top: @navigatorTopOffset + @navigatorHeaderHeight + @navigatorFiltersHeight + @navigatorFacetsHeight;
-  }
-
-  .navigator-results {
-    top: @navigatorTopOffset + @navigatorHeaderHeight + @navigatorFiltersHeight + @navigatorFacetsHeight +
-         @navigatorStatusHeight;
-  }
-
 }
 
 
-- 
2.39.5