From 297d18dd13f7b810ea5a4afeefa4cb15d9e16e16 Mon Sep 17 00:00:00 2001 From: =?utf8?q?Micha=C5=82=20Go=C5=82=C4=99biowski-Owczarek?= Date: Tue, 5 May 2020 14:16:41 +0200 Subject: [PATCH] CSS: Include `show`, `hide` & `toggle` methods in the jQuery slim build The `show()`, `hide()` & `toggle()` methods were included in the 3.x jQuery slim build. The jQuery master build accidentally started to exclude them as they were only imported in the effects module and the new Rollup-based build system follows the module dependency graph when excluding modules. To resolve the issue, import the `css/showHide.js` file directly in the main `jquery.js` file. Closes gh-4704 Ref jquery/jquery-migrate#346 --- src/jquery.js | 1 + test/unit/css.js | 5 ----- 2 files changed, 1 insertion(+), 5 deletions(-) diff --git a/src/jquery.js b/src/jquery.js index 3a27fe3ff..d9fd61afa 100644 --- a/src/jquery.js +++ b/src/jquery.js @@ -16,6 +16,7 @@ import "./manipulation/_evalUrl.js"; import "./wrap.js"; import "./css.js"; import "./css/hiddenVisibleSelectors.js"; +import "./css/showHide.js"; import "./serialize.js"; import "./ajax.js"; import "./ajax/xhr.js"; diff --git a/test/unit/css.js b/test/unit/css.js index 54a9a2fcc..095f3641b 100644 --- a/test/unit/css.js +++ b/test/unit/css.js @@ -487,9 +487,6 @@ QUnit.test( "css(Object) where values are Functions with incoming values", funct jQuery( "#cssFunctionTest" ).remove(); } ); -// .show(), .hide(), can be excluded from the build -if ( jQuery.fn.show && jQuery.fn.hide ) { - QUnit.test( "show()", function( assert ) { assert.expect( 18 ); @@ -968,8 +965,6 @@ QUnit.test( "show/hide 3.0, inline hidden", function( assert ) { } ); } ); -} - QUnit[ QUnit.jQuerySelectors && jQuery.fn.toggle ? "test" : "skip" ]( "toggle()", function( assert ) { assert.expect( 9 ); var div, oldHide, -- 2.39.5