From 2b92a02170babdf2d970ecabd2a326a0a7d64f5b Mon Sep 17 00:00:00 2001 From: Paul Bakaus Date: Mon, 24 Nov 2008 17:02:26 +0000 Subject: [PATCH] slider: fixed regression caused by a recent change in the mouse core - since the mouse core doesn't stop mousedown propagation by default now, the mousedown event was triggered twice - once by the bound handle, and once by the actual element. --- ui/ui.slider.js | 13 +++++++++++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/ui/ui.slider.js b/ui/ui.slider.js index b678d0af4..ed0644a30 100644 --- a/ui/ui.slider.js +++ b/ui/ui.slider.js @@ -72,9 +72,18 @@ $.widget("ui.slider", { // Bind the click to the slider itself this.element.bind('mousedown.slider', function(event) { + + if($(event.target).is('.ui-slider-handle')) return; + + //Go to the actual clicked posiion, apply a click self._click.apply(self, [event]); - self.currentHandle.data("mouse").trigger(event); - self.firstValue = self.firstValue + 1; //This is for always triggering the change event + + //initiate a handle drag, so we can click+drag somewhere + self.currentHandle.data("mouse").trigger(event); + + //This is for always triggering the change event + self.firstValue = self.firstValue + 1; + }); // Move the first handle to the startValue -- 2.39.5