From 2c7be656679635999e38155450e613f19c82cc29 Mon Sep 17 00:00:00 2001 From: Joonas Lehtinen Date: Sat, 14 Jun 2008 14:03:23 +0000 Subject: [PATCH] Fixed #1811: Validation logic is not logical: isRequired == false should not imply (null/"" -> valid) svn changeset:4874/svn branch:trunk --- src/com/itmill/toolkit/ui/AbstractField.java | 8 -------- 1 file changed, 8 deletions(-) diff --git a/src/com/itmill/toolkit/ui/AbstractField.java b/src/com/itmill/toolkit/ui/AbstractField.java index 72b85468cb..86fdb2bb4d 100644 --- a/src/com/itmill/toolkit/ui/AbstractField.java +++ b/src/com/itmill/toolkit/ui/AbstractField.java @@ -595,10 +595,6 @@ public abstract class AbstractField extends AbstractComponent implements Field, if (isEmpty()) { return false; } - } else { - if (isEmpty()) { - return true; - } } if (validators == null) { @@ -626,10 +622,6 @@ public abstract class AbstractField extends AbstractComponent implements Field, if (isEmpty()) { throw new Validator.InvalidValueException(""); } - } else { - if (isEmpty()) { - return; - } } // If there is no validator, there can not be any errors -- 2.39.5