From 2cf2bfdbed06cb17c704a79c33add9175eff8320 Mon Sep 17 00:00:00 2001 From: Go MAEDA Date: Thu, 12 Jan 2023 03:07:39 +0000 Subject: [PATCH] Fix redundant 'private' modifier in repositories_git_controller_test.rb (#38091). git-svn-id: https://svn.redmine.org/redmine/trunk@22040 e93f8b46-1217-0410-a6f0-8f06a7374b81 --- .rubocop_todo.yml | 6 ------ .../functional/repositories_git_controller_test.rb | 14 ++++++-------- 2 files changed, 6 insertions(+), 14 deletions(-) diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml index 837b12274..4ac8adddb 100644 --- a/.rubocop_todo.yml +++ b/.rubocop_todo.yml @@ -396,12 +396,6 @@ Lint/UnusedBlockArgument: Lint/UnusedMethodArgument: Enabled: false -# This cop supports safe autocorrection (--autocorrect). -# Configuration parameters: ContextCreatingMethods, MethodCreatingMethods. -Lint/UselessAccessModifier: - Exclude: - - 'test/functional/repositories_git_controller_test.rb' - Lint/UselessAssignment: Enabled: false diff --git a/test/functional/repositories_git_controller_test.rb b/test/functional/repositories_git_controller_test.rb index 0ffd3134c..01f745de6 100644 --- a/test/functional/repositories_git_controller_test.rb +++ b/test/functional/repositories_git_controller_test.rb @@ -810,14 +810,6 @@ class RepositoriesGitControllerTest < Redmine::RepositoryControllerTest @project.reload assert_nil @project.repository end - - private - - def puts_pass_on_not_utf8 - puts "TODO: This test fails " + - "when Encoding.default_external is not UTF-8. " + - "Current value is '#{Encoding.default_external.to_s}'" - end else puts "Git test repository NOT FOUND. Skipping functional tests !!!" def test_fake; assert true end @@ -831,4 +823,10 @@ class RepositoriesGitControllerTest < Redmine::RepositoryControllerTest yield ActionController::Base.perform_caching = before end + + def puts_pass_on_not_utf8 + puts "TODO: This test fails " + + "when Encoding.default_external is not UTF-8. " + + "Current value is '#{Encoding.default_external.to_s}'" + end end -- 2.39.5