From 2dcf50cd78b1c5d0c4ede6339c0511c254802e1b Mon Sep 17 00:00:00 2001 From: Morris Jobke Date: Thu, 15 Oct 2020 23:48:26 +0200 Subject: [PATCH] SCSSCacher - Lock should not be removed This is within the failed lock acquiring branch. So the lock is free by another process and should not be removed because the cached file (that was created by the process having the lock) appeared on the filesystem. Signed-off-by: Morris Jobke --- lib/private/Template/SCSSCacher.php | 1 - 1 file changed, 1 deletion(-) diff --git a/lib/private/Template/SCSSCacher.php b/lib/private/Template/SCSSCacher.php index cf156942592..597d4323d3c 100644 --- a/lib/private/Template/SCSSCacher.php +++ b/lib/private/Template/SCSSCacher.php @@ -169,7 +169,6 @@ class SCSSCacher { $this->logger->debug('SCSSCacher::process check in while loop follows', ['app' => 'scss_cacher']); if (!$this->variablesChanged() && $this->isCached($fileNameCSS, $app)) { // Inject icons vars css if any - $this->lockingCache->remove($lockKey); $this->logger->debug("SCSSCacher::process cached file for app '$app' and file '$fileNameCSS' is now available after $retry s. Moving on...", ['app' => 'scss_cacher']); return $this->injectCssVariablesIfAny(); } -- 2.39.5