From 2de003f6a9f0f8162e29a202abd869193950d76f Mon Sep 17 00:00:00 2001
From: Wouter Admiraal <wouter.admiraal@sonarsource.com>
Date: Mon, 15 Jun 2020 09:28:56 +0200
Subject: [PATCH] SONAR-13527 Show full filename in concise issue on hover

---
 .../apps/issues/components/ComponentBreadcrumbs.tsx  |  2 +-
 .../__snapshots__/ComponentBreadcrumbs-test.tsx.snap | 12 ++++++++++--
 .../conciseIssuesList/ConciseIssueComponent.tsx      |  7 ++++---
 .../ConciseIssueComponent-test.tsx.snap              |  5 +++--
 server/sonar-web/src/main/js/apps/issues/styles.css  |  1 +
 5 files changed, 19 insertions(+), 8 deletions(-)

diff --git a/server/sonar-web/src/main/js/apps/issues/components/ComponentBreadcrumbs.tsx b/server/sonar-web/src/main/js/apps/issues/components/ComponentBreadcrumbs.tsx
index c6f6c118dd6..b0e134740ce 100644
--- a/server/sonar-web/src/main/js/apps/issues/components/ComponentBreadcrumbs.tsx
+++ b/server/sonar-web/src/main/js/apps/issues/components/ComponentBreadcrumbs.tsx
@@ -75,7 +75,7 @@ export default function ComponentBreadcrumbs({
         </span>
       )}
 
-      {collapsePath(componentName || '')}
+      <span title={componentName}>{collapsePath(componentName || '')}</span>
     </div>
   );
 }
diff --git a/server/sonar-web/src/main/js/apps/issues/components/__tests__/__snapshots__/ComponentBreadcrumbs-test.tsx.snap b/server/sonar-web/src/main/js/apps/issues/components/__tests__/__snapshots__/ComponentBreadcrumbs-test.tsx.snap
index cdcbc76af08..82ae1824db0 100644
--- a/server/sonar-web/src/main/js/apps/issues/components/__tests__/__snapshots__/ComponentBreadcrumbs-test.tsx.snap
+++ b/server/sonar-web/src/main/js/apps/issues/components/__tests__/__snapshots__/ComponentBreadcrumbs-test.tsx.snap
@@ -16,7 +16,11 @@ exports[`renders 1`] = `
       className="slash-separator"
     />
   </span>
-  comp-name
+  <span
+    title="comp-name"
+  >
+    comp-name
+  </span>
 </div>
 `;
 
@@ -44,6 +48,10 @@ exports[`renders with sub-project 1`] = `
       className="slash-separator"
     />
   </span>
-  comp-name
+  <span
+    title="comp-name"
+  >
+    comp-name
+  </span>
 </div>
 `;
diff --git a/server/sonar-web/src/main/js/apps/issues/conciseIssuesList/ConciseIssueComponent.tsx b/server/sonar-web/src/main/js/apps/issues/conciseIssuesList/ConciseIssueComponent.tsx
index 2b48de14f2a..d267b0c4046 100644
--- a/server/sonar-web/src/main/js/apps/issues/conciseIssuesList/ConciseIssueComponent.tsx
+++ b/server/sonar-web/src/main/js/apps/issues/conciseIssuesList/ConciseIssueComponent.tsx
@@ -18,14 +18,15 @@
  * Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA.
  */
 import * as React from 'react';
-import { collapsePath } from 'sonar-ui-common/helpers/path';
 
 interface Props {
   path: string;
 }
 
-export default function ConciseIssueComponent(props: Props) {
+export default function ConciseIssueComponent({ path }: Props) {
   return (
-    <div className="concise-issue-component note text-ellipsis">{collapsePath(props.path, 20)}</div>
+    <div className="concise-issue-component text-ellipsis note" title={path}>
+      {path}
+    </div>
   );
 }
diff --git a/server/sonar-web/src/main/js/apps/issues/conciseIssuesList/__tests__/__snapshots__/ConciseIssueComponent-test.tsx.snap b/server/sonar-web/src/main/js/apps/issues/conciseIssuesList/__tests__/__snapshots__/ConciseIssueComponent-test.tsx.snap
index a03391a8105..6a04ea2c1dc 100644
--- a/server/sonar-web/src/main/js/apps/issues/conciseIssuesList/__tests__/__snapshots__/ConciseIssueComponent-test.tsx.snap
+++ b/server/sonar-web/src/main/js/apps/issues/conciseIssuesList/__tests__/__snapshots__/ConciseIssueComponent-test.tsx.snap
@@ -2,8 +2,9 @@
 
 exports[`should render 1`] = `
 <div
-  className="concise-issue-component note text-ellipsis"
+  className="concise-issue-component text-ellipsis note"
+  title="src/app/folder/sub-folder/long-folder/name/app.js"
 >
-  src/.../long-folder/name/app.js
+  src/app/folder/sub-folder/long-folder/name/app.js
 </div>
 `;
diff --git a/server/sonar-web/src/main/js/apps/issues/styles.css b/server/sonar-web/src/main/js/apps/issues/styles.css
index 88402d912af..1c166a3a065 100644
--- a/server/sonar-web/src/main/js/apps/issues/styles.css
+++ b/server/sonar-web/src/main/js/apps/issues/styles.css
@@ -54,6 +54,7 @@
   margin-bottom: calc(var(--gridSize) / 2);
   padding-left: var(--gridSize);
   padding-right: var(--gridSize);
+  direction: rtl;
 }
 
 .concise-issue-box {
-- 
2.39.5