From 2e92279e6f0f2bdea326b39fc50b740ca7f224b5 Mon Sep 17 00:00:00 2001 From: Simon Brandhof Date: Wed, 5 Dec 2012 15:06:30 +0100 Subject: [PATCH] Fix quality flaws --- .../plugins/core/filters/MyFavouritesFilter.java | 11 +++++------ .../wsclient/connectors/HttpClient4Connector.java | 2 -- 2 files changed, 5 insertions(+), 8 deletions(-) diff --git a/plugins/sonar-core-plugin/src/main/java/org/sonar/plugins/core/filters/MyFavouritesFilter.java b/plugins/sonar-core-plugin/src/main/java/org/sonar/plugins/core/filters/MyFavouritesFilter.java index 849300497b9..ea66def1484 100644 --- a/plugins/sonar-core-plugin/src/main/java/org/sonar/plugins/core/filters/MyFavouritesFilter.java +++ b/plugins/sonar-core-plugin/src/main/java/org/sonar/plugins/core/filters/MyFavouritesFilter.java @@ -20,7 +20,6 @@ package org.sonar.plugins.core.filters; import org.sonar.api.measures.CoreMetrics; -import org.sonar.api.web.Criterion; import org.sonar.api.web.Filter; import org.sonar.api.web.FilterColumn; import org.sonar.api.web.FilterTemplate; @@ -41,10 +40,10 @@ public class MyFavouritesFilter extends FilterTemplate { @Override public Filter createFilter() { return Filter.create() - .setDisplayAs(Filter.LIST) - .setFavouritesOnly(true) - .add(FilterColumn.create("metric", CoreMetrics.ALERT_STATUS_KEY, FilterColumn.DESC, false)) - .add(FilterColumn.create("name", null, FilterColumn.ASC, false)) - .add(FilterColumn.create("date", null, FilterColumn.DESC, false)); + .setDisplayAs(Filter.LIST) + .setFavouritesOnly(true) + .add(FilterColumn.create("metric", CoreMetrics.ALERT_STATUS_KEY, FilterColumn.DESC, false)) + .add(FilterColumn.create("name", null, FilterColumn.ASC, false)) + .add(FilterColumn.create("date", null, FilterColumn.DESC, false)); } } diff --git a/sonar-ws-client/src/main/java/org/sonar/wsclient/connectors/HttpClient4Connector.java b/sonar-ws-client/src/main/java/org/sonar/wsclient/connectors/HttpClient4Connector.java index 905f2ef7ba5..8fe879763b4 100644 --- a/sonar-ws-client/src/main/java/org/sonar/wsclient/connectors/HttpClient4Connector.java +++ b/sonar-ws-client/src/main/java/org/sonar/wsclient/connectors/HttpClient4Connector.java @@ -32,7 +32,6 @@ import org.apache.http.auth.AuthState; import org.apache.http.auth.Credentials; import org.apache.http.auth.UsernamePasswordCredentials; import org.apache.http.client.CredentialsProvider; -import org.apache.http.client.HttpClient; import org.apache.http.client.methods.HttpDelete; import org.apache.http.client.methods.HttpEntityEnclosingRequestBase; import org.apache.http.client.methods.HttpGet; @@ -42,7 +41,6 @@ import org.apache.http.client.methods.HttpRequestBase; import org.apache.http.client.protocol.ClientContext; import org.apache.http.entity.StringEntity; import org.apache.http.impl.auth.BasicScheme; -import org.apache.http.impl.client.AbstractHttpClient; import org.apache.http.impl.client.DefaultHttpClient; import org.apache.http.params.CoreConnectionPNames; import org.apache.http.params.HttpConnectionParams; -- 2.39.5