From 2f82c22692ce75f637dfcacaaf8ccfb3279e368d Mon Sep 17 00:00:00 2001 From: Jean-Baptiste Lievremont Date: Tue, 14 Apr 2015 13:20:33 +0200 Subject: [PATCH] SONAR-6294 Show "isDefault" attribute even when false --- .../sonar/server/qualityprofile/ws/QProfileSearchAction.java | 4 ++-- .../qualityprofile/ws/QProfileSearchActionTest/search.json | 2 ++ 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/server/sonar-server/src/main/java/org/sonar/server/qualityprofile/ws/QProfileSearchAction.java b/server/sonar-server/src/main/java/org/sonar/server/qualityprofile/ws/QProfileSearchAction.java index ee9d94e83ac..9560c6b1422 100644 --- a/server/sonar-server/src/main/java/org/sonar/server/qualityprofile/ws/QProfileSearchAction.java +++ b/server/sonar-server/src/main/java/org/sonar/server/qualityprofile/ws/QProfileSearchAction.java @@ -145,8 +145,8 @@ public class QProfileSearchAction implements BaseQProfileWsAction { if (fieldIsNeeded(FIELD_IS_INHERITED, fields)) { json.prop(FIELD_IS_INHERITED, profile.isInherited()); } - if (fieldIsNeeded(FIELD_IS_DEFAULT, fields) && profile.isDefault()) { - json.prop(FIELD_IS_DEFAULT, true); + if (fieldIsNeeded(FIELD_IS_DEFAULT, fields)) { + json.prop(FIELD_IS_DEFAULT, profile.isDefault()); } json.endObject(); } diff --git a/server/sonar-server/src/test/resources/org/sonar/server/qualityprofile/ws/QProfileSearchActionTest/search.json b/server/sonar-server/src/test/resources/org/sonar/server/qualityprofile/ws/QProfileSearchActionTest/search.json index 1d49787a6c6..b800f3a3bce 100644 --- a/server/sonar-server/src/test/resources/org/sonar/server/qualityprofile/ws/QProfileSearchActionTest/search.json +++ b/server/sonar-server/src/test/resources/org/sonar/server/qualityprofile/ws/QProfileSearchActionTest/search.json @@ -15,6 +15,7 @@ "language": "xoo2", "languageName": "Xoo2", "isInherited": true, + "isDefault": false, "parentKey": "sonar-way-xoo2-23456", "parentName": "Sonar way", "activeRuleCount": 33 @@ -25,6 +26,7 @@ "language": "xoo2", "languageName": "Xoo2", "isInherited": false, + "isDefault": false, "activeRuleCount": 0 } ] -- 2.39.5