From 329184bd9670935142edde43fd9c0f2bd75076d0 Mon Sep 17 00:00:00 2001 From: Toshi MARUYAMA Date: Wed, 23 Oct 2019 13:32:17 +0000 Subject: [PATCH] rubocop: generate .rubocop_todo.yml with "--exclude-limit 20" git-svn-id: http://svn.redmine.org/redmine/trunk@18858 e93f8b46-1217-0410-a6f0-8f06a7374b81 --- .rubocop_todo.yml | 287 +++++++++++++++++++++++++++++++++++++++++++--- 1 file changed, 272 insertions(+), 15 deletions(-) diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml index 06bdb3488..68241975b 100644 --- a/.rubocop_todo.yml +++ b/.rubocop_todo.yml @@ -1,5 +1,5 @@ # This configuration was generated by -# `rubocop --auto-gen-config --no-offense-counts --no-auto-gen-timestamp` +# `rubocop --auto-gen-config --exclude-limit 20 --no-offense-counts --no-auto-gen-timestamp` # using RuboCop version 0.75.0. # The point is for the user to remove these configuration records # one by one as the offenses are removed from the code base. @@ -134,7 +134,25 @@ Layout/IndentFirstArgument: # Configuration parameters: EnforcedStyle, IndentationWidth. # SupportedStyles: special_inside_parentheses, consistent, align_brackets Layout/IndentFirstArrayElement: - Enabled: false + Exclude: + - 'app/helpers/workflows_helper.rb' + - 'app/models/project.rb' + - 'app/models/setting.rb' + - 'lib/redmine/nested_set/issue_nested_set.rb' + - 'lib/redmine/nested_set/project_nested_set.rb' + - 'lib/redmine/wiki_formatting/textile/redcloth3.rb' + - 'test/functional/auth_sources_controller_test.rb' + - 'test/functional/repositories_mercurial_controller_test.rb' + - 'test/functional/settings_controller_test.rb' + - 'test/helpers/activities_helper_test.rb' + - 'test/helpers/issues_helper_test.rb' + - 'test/integration/api_test/issues_test.rb' + - 'test/unit/issue_test.rb' + - 'test/unit/lib/redmine/scm/adapters/git_adapter_test.rb' + - 'test/unit/lib/redmine/scm/adapters/mercurial_adapter_test.rb' + - 'test/unit/project_test.rb' + - 'test/unit/repository_git_test.rb' + - 'test/unit/version_test.rb' # Cop supports --auto-correct. # Configuration parameters: EnforcedStyle, IndentationWidth. @@ -217,7 +235,25 @@ Layout/SpaceAfterComma: # Cop supports --auto-correct. Layout/SpaceAfterNot: - Enabled: false + Exclude: + - 'app/controllers/application_controller.rb' + - 'app/models/repository/cvs.rb' + - 'app/models/repository/git.rb' + - 'lib/redmine/codeset_util.rb' + - 'test/functional/account_controller_test.rb' + - 'test/functional/documents_controller_test.rb' + - 'test/functional/issues_controller_test.rb' + - 'test/functional/repositories_git_controller_test.rb' + - 'test/functional/timelog_controller_test.rb' + - 'test/functional/workflows_controller_test.rb' + - 'test/helpers/application_helper_test.rb' + - 'test/unit/attachment_test.rb' + - 'test/unit/lib/redmine/export/pdf_test.rb' + - 'test/unit/project_copy_test.rb' + - 'test/unit/project_test.rb' + - 'test/unit/query_test.rb' + - 'test/unit/role_test.rb' + - 'test/unit/user_test.rb' # Cop supports --auto-correct. # Configuration parameters: EnforcedStyle. @@ -297,7 +333,27 @@ Layout/SpaceInsideHashLiteralBraces: # Configuration parameters: EnforcedStyle. # SupportedStyles: space, no_space Layout/SpaceInsideParens: - Enabled: false + Exclude: + - 'app/controllers/application_controller.rb' + - 'app/helpers/issues_helper.rb' + - 'app/models/auth_source_ldap.rb' + - 'app/models/repository/cvs.rb' + - 'app/models/repository/mercurial.rb' + - 'lib/redmine/scm/adapters/abstract_adapter.rb' + - 'lib/redmine/scm/adapters/cvs_adapter.rb' + - 'lib/redmine/scm/adapters/git_adapter.rb' + - 'lib/redmine/scm/adapters/mercurial_adapter.rb' + - 'lib/redmine/sudo_mode.rb' + - 'lib/redmine/wiki_formatting/textile/formatter.rb' + - 'lib/redmine/wiki_formatting/textile/redcloth3.rb' + - 'test/helpers/application_helper_test.rb' + - 'test/unit/changeset_test.rb' + - 'test/unit/issue_subtasking_test.rb' + - 'test/unit/lib/redmine/export/pdf_test.rb' + - 'test/unit/lib/redmine/wiki_formatting/textile_formatter_test.rb' + - 'test/unit/query_test.rb' + - 'test/unit/repository_test.rb' + - 'test/unit/user_test.rb' # Cop supports --auto-correct. Layout/SpaceInsidePercentLiteralDelimiters: @@ -703,7 +759,26 @@ Rails/HttpStatus: # Configuration parameters: Include. # Include: app/models/**/*.rb Rails/InverseOf: - Enabled: false + Exclude: + - 'app/models/board.rb' + - 'app/models/custom_field.rb' + - 'app/models/document_category.rb' + - 'app/models/issue.rb' + - 'app/models/issue_category.rb' + - 'app/models/issue_priority.rb' + - 'app/models/issue_status.rb' + - 'app/models/journal.rb' + - 'app/models/member.rb' + - 'app/models/news.rb' + - 'app/models/principal.rb' + - 'app/models/project.rb' + - 'app/models/repository.rb' + - 'app/models/repository/mercurial.rb' + - 'app/models/time_entry_activity.rb' + - 'app/models/user.rb' + - 'app/models/version.rb' + - 'app/models/wiki.rb' + - 'app/models/wiki_page.rb' # Configuration parameters: Include. # Include: app/controllers/**/*.rb @@ -758,7 +833,24 @@ Rails/Present: # Configuration parameters: Include. # Include: app/models/**/*.rb Rails/ReadWriteAttribute: - Enabled: false + Exclude: + - 'app/models/attachment.rb' + - 'app/models/auth_source_ldap.rb' + - 'app/models/changeset.rb' + - 'app/models/custom_field.rb' + - 'app/models/email_address.rb' + - 'app/models/issue.rb' + - 'app/models/journal_detail.rb' + - 'app/models/message.rb' + - 'app/models/query.rb' + - 'app/models/repository.rb' + - 'app/models/repository/git.rb' + - 'app/models/role.rb' + - 'app/models/setting.rb' + - 'app/models/time_entry.rb' + - 'app/models/user.rb' + - 'app/models/user_preference.rb' + - 'app/models/wiki_page.rb' Rails/ReflectionClassName: Exclude: @@ -822,13 +914,46 @@ Style/AccessModifierDeclarations: # Configuration parameters: EnforcedStyle. # SupportedStyles: prefer_alias, prefer_alias_method Style/Alias: - Enabled: false + Exclude: + - 'app/controllers/repositories_controller.rb' + - 'app/models/custom_field_enumeration.rb' + - 'app/models/enumeration.rb' + - 'app/models/issue.rb' + - 'app/models/issue_category.rb' + - 'app/models/issue_query.rb' + - 'app/models/issue_status.rb' + - 'app/models/member.rb' + - 'app/models/project.rb' + - 'app/models/user.rb' + - 'app/models/version.rb' + - 'config/initializers/10-patches.rb' + - 'lib/redmine/export/pdf.rb' + - 'lib/redmine/menu_manager.rb' + - 'lib/redmine/plugin.rb' + - 'lib/redmine/wiki_formatting/markdown/formatter.rb' + - 'lib/redmine/wiki_formatting/textile/formatter.rb' # Cop supports --auto-correct. # Configuration parameters: EnforcedStyle. # SupportedStyles: always, conditionals Style/AndOr: - Enabled: false + Exclude: + - 'app/controllers/account_controller.rb' + - 'app/controllers/application_controller.rb' + - 'app/controllers/calendars_controller.rb' + - 'app/helpers/repositories_helper.rb' + - 'app/models/query.rb' + - 'db/migrate/022_serialize_possibles_values.rb' + - 'lib/redmine/export/pdf.rb' + - 'lib/redmine/field_format.rb' + - 'lib/redmine/helpers/gantt.rb' + - 'lib/redmine/scm/adapters/abstract_adapter.rb' + - 'lib/redmine/scm/adapters/bazaar_adapter.rb' + - 'lib/redmine/scm/adapters/filesystem_adapter.rb' + - 'lib/redmine/scm/adapters/git_adapter.rb' + - 'lib/redmine/scm/adapters/subversion_adapter.rb' + - 'lib/redmine/wiki_formatting.rb' + - 'lib/redmine/wiki_formatting/textile/redcloth3.rb' # Cop supports --auto-correct. # Configuration parameters: EnforcedStyle. @@ -869,7 +994,26 @@ Style/ClassMethods: - 'lib/diff.rb' Style/ClassVars: - Enabled: false + Exclude: + - 'app/models/attachment.rb' + - 'config/initializers/10-patches.rb' + - 'lib/redmine/activity.rb' + - 'lib/redmine/export/pdf.rb' + - 'lib/redmine/hook.rb' + - 'lib/redmine/i18n.rb' + - 'lib/redmine/menu_manager.rb' + - 'lib/redmine/my_page.rb' + - 'lib/redmine/scm/adapters/bazaar_adapter.rb' + - 'lib/redmine/scm/adapters/cvs_adapter.rb' + - 'lib/redmine/scm/adapters/git_adapter.rb' + - 'lib/redmine/scm/adapters/mercurial_adapter.rb' + - 'lib/redmine/scm/adapters/subversion_adapter.rb' + - 'lib/redmine/search.rb' + - 'lib/redmine/themes.rb' + - 'lib/redmine/wiki_formatting.rb' + - 'lib/redmine/wiki_formatting/macros.rb' + - 'lib/redmine/wiki_formatting/markdown/formatter.rb' + - 'test/helpers/activities_helper_test.rb' # Cop supports --auto-correct. Style/ColonMethodCall: @@ -907,7 +1051,27 @@ Style/DoubleNegation: # Cop supports --auto-correct. Style/EachWithObject: - Enabled: false + Exclude: + - 'app/controllers/repositories_controller.rb' + - 'app/helpers/queries_helper.rb' + - 'app/models/issue.rb' + - 'app/models/issue_import.rb' + - 'app/models/journal.rb' + - 'app/models/mail_handler.rb' + - 'app/models/project.rb' + - 'app/models/query.rb' + - 'app/models/repository.rb' + - 'app/models/setting.rb' + - 'app/models/time_entry_import.rb' + - 'app/models/workflow_permission.rb' + - 'config/initializers/10-patches.rb' + - 'lib/redmine/acts/positioned.rb' + - 'lib/redmine/configuration.rb' + - 'lib/redmine/i18n.rb' + - 'lib/redmine/mime_type.rb' + - 'lib/redmine/my_page.rb' + - 'lib/redmine/sort_criteria.rb' + - 'test/test_helper.rb' # Cop supports --auto-correct. Style/EmptyCaseCondition: @@ -974,7 +1138,24 @@ Style/GuardClause: # Configuration parameters: AllowIfModifier. Style/IfInsideElse: - Enabled: false + Exclude: + - 'app/controllers/account_controller.rb' + - 'app/controllers/activities_controller.rb' + - 'app/controllers/application_controller.rb' + - 'app/helpers/application_helper.rb' + - 'app/helpers/issues_helper.rb' + - 'app/models/custom_field.rb' + - 'app/models/issue.rb' + - 'app/models/project.rb' + - 'app/models/query.rb' + - 'app/models/version.rb' + - 'config/initializers/10-patches.rb' + - 'lib/redmine/field_format.rb' + - 'lib/redmine/helpers/gantt.rb' + - 'lib/redmine/menu_manager.rb' + - 'lib/redmine/pop3.rb' + - 'lib/redmine/scm/adapters/bazaar_adapter.rb' + - 'lib/redmine/views/builders/structure.rb' # Cop supports --auto-correct. Style/IfUnlessModifier: @@ -987,7 +1168,27 @@ Style/IfUnlessModifierOfIfUnless: # Cop supports --auto-correct. # Configuration parameters: InverseMethods, InverseBlocks. Style/InverseMethods: - Enabled: false + Exclude: + - 'app/controllers/roles_controller.rb' + - 'app/helpers/application_helper.rb' + - 'app/helpers/issues_helper.rb' + - 'app/helpers/repositories_helper.rb' + - 'app/models/document.rb' + - 'app/models/issue.rb' + - 'app/models/member.rb' + - 'app/models/message.rb' + - 'app/models/project.rb' + - 'app/models/tracker.rb' + - 'app/models/version.rb' + - 'app/models/wiki_content.rb' + - 'db/migrate/096_add_commit_access_permission.rb' + - 'lib/redmine/default_data/loader.rb' + - 'lib/redmine/helpers/diff.rb' + - 'lib/redmine/scm/adapters/abstract_adapter.rb' + - 'lib/redmine/scm/adapters/git_adapter.rb' + - 'lib/redmine/wiki_formatting/textile/redcloth3.rb' + - 'test/unit/issue_test.rb' + - 'test/unit/query_test.rb' # Cop supports --auto-correct. # Configuration parameters: EnforcedStyle. @@ -1035,7 +1236,27 @@ Style/MultilineBlockChain: # Cop supports --auto-correct. Style/MultilineIfModifier: - Enabled: false + Exclude: + - 'app/helpers/application_helper.rb' + - 'app/helpers/attachments_helper.rb' + - 'app/helpers/custom_fields_helper.rb' + - 'app/helpers/projects_helper.rb' + - 'app/helpers/reports_helper.rb' + - 'app/helpers/repositories_helper.rb' + - 'app/helpers/search_helper.rb' + - 'app/models/issue_query.rb' + - 'app/models/query.rb' + - 'app/models/repository/bazaar.rb' + - 'app/models/repository/subversion.rb' + - 'app/models/time_entry_query.rb' + - 'app/views/common/feed.atom.builder' + - 'lib/redmine/access_keys.rb' + - 'lib/redmine/helpers/gantt.rb' + - 'lib/redmine/scm/adapters/git_adapter.rb' + - 'lib/redmine/scm/adapters/subversion_adapter.rb' + - 'lib/redmine/wiki_formatting.rb' + - 'lib/redmine/wiki_formatting/textile/redcloth3.rb' + - 'test/mocks/open_id_authentication_mock.rb' Style/MultilineTernaryOperator: Exclude: @@ -1199,7 +1420,25 @@ Style/RedundantConditional: # Cop supports --auto-correct. Style/RedundantParentheses: - Enabled: false + Exclude: + - 'app/controllers/search_controller.rb' + - 'app/helpers/users_helper.rb' + - 'app/models/enumeration.rb' + - 'app/models/principal.rb' + - 'app/models/query.rb' + - 'app/models/repository/cvs.rb' + - 'app/models/version.rb' + - 'lib/redmine/field_format.rb' + - 'lib/redmine/helpers/gantt.rb' + - 'lib/redmine/platform.rb' + - 'lib/redmine/scm/adapters/cvs_adapter.rb' + - 'lib/redmine/scm/adapters/filesystem_adapter.rb' + - 'test/helpers/application_helper_test.rb' + - 'test/unit/attachment_test.rb' + - 'test/unit/lib/redmine/export/pdf_test.rb' + - 'test/unit/project_test.rb' + - 'test/unit/user_test.rb' + - 'test/unit/version_test.rb' # Cop supports --auto-correct. # Configuration parameters: AllowMultipleReturnValues. @@ -1264,7 +1503,25 @@ Style/SelfAssignment: # Cop supports --auto-correct. # Configuration parameters: AllowAsExpressionSeparator. Style/Semicolon: - Enabled: false + Exclude: + - 'app/controllers/account_controller.rb' + - 'app/controllers/context_menus_controller.rb' + - 'app/controllers/journals_controller.rb' + - 'app/controllers/messages_controller.rb' + - 'app/controllers/repositories_controller.rb' + - 'app/controllers/search_controller.rb' + - 'app/models/issue.rb' + - 'app/models/issue_query.rb' + - 'app/models/journal.rb' + - 'app/models/mail_handler.rb' + - 'app/models/project.rb' + - 'app/models/query.rb' + - 'app/models/tracker.rb' + - 'lib/redmine/configuration.rb' + - 'lib/redmine/i18n.rb' + - 'lib/redmine/scm/adapters/git_adapter.rb' + - 'lib/redmine/sort_criteria.rb' + - 'lib/redmine/wiki_formatting/textile/redcloth3.rb' # Cop supports --auto-correct. # Configuration parameters: AllowIfMethodIsEmpty. -- 2.39.5