From 37eacc717911777f4679f6150db018eb652f3cb9 Mon Sep 17 00:00:00 2001 From: Jean-Baptiste Vilain Date: Tue, 6 Aug 2013 10:45:02 +0200 Subject: [PATCH] SONAR-3858 - Fixed quality issue --- .../core/timemachine/AbstractNewCoverageFileAnalyzer.java | 5 ----- .../core/timemachine/NewCoverageFileAnalyzerTest.java | 2 +- 2 files changed, 1 insertion(+), 6 deletions(-) diff --git a/plugins/sonar-core-plugin/src/main/java/org/sonar/plugins/core/timemachine/AbstractNewCoverageFileAnalyzer.java b/plugins/sonar-core-plugin/src/main/java/org/sonar/plugins/core/timemachine/AbstractNewCoverageFileAnalyzer.java index 126ba4e0098..4c13b404164 100644 --- a/plugins/sonar-core-plugin/src/main/java/org/sonar/plugins/core/timemachine/AbstractNewCoverageFileAnalyzer.java +++ b/plugins/sonar-core-plugin/src/main/java/org/sonar/plugins/core/timemachine/AbstractNewCoverageFileAnalyzer.java @@ -152,11 +152,6 @@ public abstract class AbstractNewCoverageFileAnalyzer implements Decorator { newUncoveredLines.setVariation(struct.index, (double) (struct.getNewLines() - struct.getNewCoveredLines())); newConditions.setVariation(struct.index, (double) struct.getNewConditions()); newUncoveredConditions.setVariation(struct.index, (double) struct.getNewConditions() - struct.getNewCoveredConditions()); - } else { - newLines.setVariation(struct.index, null); - newUncoveredLines.setVariation(struct.index, null); - newConditions.setVariation(struct.index, null); - newUncoveredConditions.setVariation(struct.index, null); } } diff --git a/plugins/sonar-core-plugin/src/test/java/org/sonar/plugins/core/timemachine/NewCoverageFileAnalyzerTest.java b/plugins/sonar-core-plugin/src/test/java/org/sonar/plugins/core/timemachine/NewCoverageFileAnalyzerTest.java index e49d9525a5a..de292905b43 100644 --- a/plugins/sonar-core-plugin/src/test/java/org/sonar/plugins/core/timemachine/NewCoverageFileAnalyzerTest.java +++ b/plugins/sonar-core-plugin/src/test/java/org/sonar/plugins/core/timemachine/NewCoverageFileAnalyzerTest.java @@ -143,7 +143,7 @@ public class NewCoverageFileAnalyzerTest { } @Test - public void shouldSetNullValueWhenNothingHasChanged() throws Exception { + public void shouldLeaveNullValueWhenNothingHasChanged() throws Exception { String lastCommitDatesByLine = "1=2008-08-02T13:56:37+0200;" + "2=2008-08-02T13:56:37+0200;" + "3=2008-08-02T13:56:37+0200;" + -- 2.39.5