From 382d37fe1a447e5fe23e77ceffff6d00430792c1 Mon Sep 17 00:00:00 2001 From: Simon Brandhof Date: Tue, 20 Mar 2018 18:34:47 +0100 Subject: [PATCH] GOV-341 stop persisting project_measures on project copies --- .../task/projectanalysis/step/PersistMeasuresStep.java | 2 +- .../task/projectanalysis/step/PersistMeasuresStepTest.java | 3 +-- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/server/sonar-server/src/main/java/org/sonar/server/computation/task/projectanalysis/step/PersistMeasuresStep.java b/server/sonar-server/src/main/java/org/sonar/server/computation/task/projectanalysis/step/PersistMeasuresStep.java index ce769e0c874..9182da798c8 100644 --- a/server/sonar-server/src/main/java/org/sonar/server/computation/task/projectanalysis/step/PersistMeasuresStep.java +++ b/server/sonar-server/src/main/java/org/sonar/server/computation/task/projectanalysis/step/PersistMeasuresStep.java @@ -121,7 +121,7 @@ public class PersistMeasuresStep implements ComputationStep { @Override public void visitProjectView(Component projectView) { - persistMeasures(projectView); + // measures of project copies are never read. No need to persist them. } private void persistMeasures(Component component) { diff --git a/server/sonar-server/src/test/java/org/sonar/server/computation/task/projectanalysis/step/PersistMeasuresStepTest.java b/server/sonar-server/src/test/java/org/sonar/server/computation/task/projectanalysis/step/PersistMeasuresStepTest.java index 831c868d9f0..3711f28ecce 100644 --- a/server/sonar-server/src/test/java/org/sonar/server/computation/task/projectanalysis/step/PersistMeasuresStepTest.java +++ b/server/sonar-server/src/test/java/org/sonar/server/computation/task/projectanalysis/step/PersistMeasuresStepTest.java @@ -159,10 +159,9 @@ public class PersistMeasuresStepTest extends BaseStepTest { execute(true); - assertThat(db.countRowsOfTable("project_measures")).isEqualTo(3); + assertThat(db.countRowsOfTable("project_measures")).isEqualTo(2); assertThat(selectMeasure("view-uuid", STRING_METRIC).get().getData()).isEqualTo("view-value"); assertThat(selectMeasure("subview-uuid", STRING_METRIC).get().getData()).isEqualTo("subview-value"); - assertThat(selectMeasure("project-uuid", STRING_METRIC).get().getData()).isEqualTo("project-value"); } private void prepareProject() { -- 2.39.5