From 3fb3b68fade28709979c6a3c0882c1ae2a6a37fb Mon Sep 17 00:00:00 2001
From: Henri Sara <henri.sara@itmill.com>
Date: Tue, 1 Jun 2010 11:11:24 +0000
Subject: [PATCH] Fixed some normal priority warnings by FindBugs

svn changeset:13461/svn branch:6.3
---
 tests/src/com/vaadin/tests/StressComponentsInTable.java   | 6 +++---
 tests/src/com/vaadin/tests/book/TableEditable.java        | 6 +++---
 tests/src/com/vaadin/tests/components/button/Buttons.java | 6 +++---
 .../com/vaadin/tests/components/combobox/Comboboxes.java  | 6 +++---
 .../src/com/vaadin/tests/components/label/LabelModes.java | 6 +++---
 tests/src/com/vaadin/tests/components/label/Labels.java   | 6 +++---
 .../src/com/vaadin/tests/components/menubar/Menubars.java | 6 +++---
 .../tests/components/richtextarea/RichTextAreas.java      | 8 ++++----
 .../com/vaadin/tests/components/select/NativeSelects.java | 8 ++++----
 .../com/vaadin/tests/components/textfield/TextFields.java | 8 ++++----
 .../com/vaadin/tests/featurebrowser/PropertyPanel.java    | 4 ++--
 11 files changed, 35 insertions(+), 35 deletions(-)

diff --git a/tests/src/com/vaadin/tests/StressComponentsInTable.java b/tests/src/com/vaadin/tests/StressComponentsInTable.java
index 6f04f5b731..7e072eabd7 100644
--- a/tests/src/com/vaadin/tests/StressComponentsInTable.java
+++ b/tests/src/com/vaadin/tests/StressComponentsInTable.java
@@ -39,9 +39,9 @@ public class StressComponentsInTable extends CustomComponent {
 
                 public void buttonClick(ClickEvent event) {
                     Button b = event.getButton();
-                    System.out.println(event.getButton().getCaption()
-                            + " click: " + (new Date()).toGMTString());
-                    System.out.println(event.getButton().getApplication());
+                    System.out.println(b.getCaption() + " click: "
+                            + (new Date()).toGMTString());
+                    System.out.println(b.getApplication());
 
                 }
             }));
diff --git a/tests/src/com/vaadin/tests/book/TableEditable.java b/tests/src/com/vaadin/tests/book/TableEditable.java
index 0beefba320..3e5dc0e613 100644
--- a/tests/src/com/vaadin/tests/book/TableEditable.java
+++ b/tests/src/com/vaadin/tests/book/TableEditable.java
@@ -36,9 +36,9 @@ public class TableEditable extends CustomComponent {
             calendar.add(Calendar.DAY_OF_YEAR, i);
 
             // Create the table row.
-            table.addItem(new Object[] { calendar.getTime(),
-                    new Boolean(false), "" }, new Integer(i)); // Item
-            // identifier
+            table.addItem(
+                    new Object[] { calendar.getTime(), Boolean.FALSE, "" },
+                    new Integer(i)); // Item identifier
         }
 
         table.setPageLength(8);
diff --git a/tests/src/com/vaadin/tests/components/button/Buttons.java b/tests/src/com/vaadin/tests/components/button/Buttons.java
index 0540a0dcde..1c5c35e237 100644
--- a/tests/src/com/vaadin/tests/components/button/Buttons.java
+++ b/tests/src/com/vaadin/tests/components/button/Buttons.java
@@ -100,9 +100,9 @@ public class Buttons extends ComponentTestCase<Button> {
                     }
                 });
 
-        errorIndicators.setValue(new Boolean(false));
-        readonly.setValue(new Boolean(false));
-        enabled.setValue(new Boolean(true));
+        errorIndicators.setValue(Boolean.FALSE);
+        readonly.setValue(Boolean.FALSE);
+        enabled.setValue(Boolean.TRUE);
 
         errorIndicators.setImmediate(true);
         readonly.setImmediate(true);
diff --git a/tests/src/com/vaadin/tests/components/combobox/Comboboxes.java b/tests/src/com/vaadin/tests/components/combobox/Comboboxes.java
index 39008f3db5..40a70fa92a 100644
--- a/tests/src/com/vaadin/tests/components/combobox/Comboboxes.java
+++ b/tests/src/com/vaadin/tests/components/combobox/Comboboxes.java
@@ -150,9 +150,9 @@ public class Comboboxes extends ComponentTestCase<ComboBox> {
                     }
                 });
 
-        errorIndicators.setValue(new Boolean(false));
-        readonly.setValue(new Boolean(false));
-        enabled.setValue(new Boolean(true));
+        errorIndicators.setValue(Boolean.FALSE);
+        readonly.setValue(Boolean.FALSE);
+        enabled.setValue(Boolean.TRUE);
 
         errorIndicators.setImmediate(true);
         readonly.setImmediate(true);
diff --git a/tests/src/com/vaadin/tests/components/label/LabelModes.java b/tests/src/com/vaadin/tests/components/label/LabelModes.java
index d7d426ec88..88ff296739 100644
--- a/tests/src/com/vaadin/tests/components/label/LabelModes.java
+++ b/tests/src/com/vaadin/tests/components/label/LabelModes.java
@@ -91,9 +91,9 @@ public class LabelModes extends ComponentTestCase<Label> {
                     }
                 });
 
-        errorIndicators.setValue(new Boolean(false));
-        readonly.setValue(new Boolean(false));
-        enabled.setValue(new Boolean(true));
+        errorIndicators.setValue(Boolean.FALSE);
+        readonly.setValue(Boolean.FALSE);
+        enabled.setValue(Boolean.TRUE);
 
         errorIndicators.setImmediate(true);
         readonly.setImmediate(true);
diff --git a/tests/src/com/vaadin/tests/components/label/Labels.java b/tests/src/com/vaadin/tests/components/label/Labels.java
index 64c61ba13c..7bc7722b35 100644
--- a/tests/src/com/vaadin/tests/components/label/Labels.java
+++ b/tests/src/com/vaadin/tests/components/label/Labels.java
@@ -102,9 +102,9 @@ public class Labels extends ComponentTestCase<Label> {
                     }
                 });
 
-        errorIndicators.setValue(new Boolean(false));
-        readonly.setValue(new Boolean(false));
-        enabled.setValue(new Boolean(true));
+        errorIndicators.setValue(Boolean.FALSE);
+        readonly.setValue(Boolean.FALSE);
+        enabled.setValue(Boolean.TRUE);
 
         errorIndicators.setImmediate(true);
         readonly.setImmediate(true);
diff --git a/tests/src/com/vaadin/tests/components/menubar/Menubars.java b/tests/src/com/vaadin/tests/components/menubar/Menubars.java
index 0442225134..0c059b82db 100644
--- a/tests/src/com/vaadin/tests/components/menubar/Menubars.java
+++ b/tests/src/com/vaadin/tests/components/menubar/Menubars.java
@@ -108,9 +108,9 @@ public class Menubars extends ComponentTestCase<MenuBar> {
                     }
                 });
 
-        errorIndicators.setValue(new Boolean(false));
-        readonly.setValue(new Boolean(false));
-        enabled.setValue(new Boolean(true));
+        errorIndicators.setValue(Boolean.FALSE);
+        readonly.setValue(Boolean.FALSE);
+        enabled.setValue(Boolean.TRUE);
 
         errorIndicators.setImmediate(true);
         readonly.setImmediate(true);
diff --git a/tests/src/com/vaadin/tests/components/richtextarea/RichTextAreas.java b/tests/src/com/vaadin/tests/components/richtextarea/RichTextAreas.java
index e3e12a1c8d..71030d6b15 100644
--- a/tests/src/com/vaadin/tests/components/richtextarea/RichTextAreas.java
+++ b/tests/src/com/vaadin/tests/components/richtextarea/RichTextAreas.java
@@ -96,10 +96,10 @@ public class RichTextAreas extends ComponentTestCase<RichTextArea> {
                     }
                 });
 
-        errorIndicators.setValue(new Boolean(false));
-        required.setValue(new Boolean(false));
-        readonly.setValue(new Boolean(false));
-        enabled.setValue(new Boolean(true));
+        errorIndicators.setValue(Boolean.FALSE);
+        required.setValue(Boolean.FALSE);
+        readonly.setValue(Boolean.FALSE);
+        enabled.setValue(Boolean.TRUE);
 
         errorIndicators.setImmediate(true);
         required.setImmediate(true);
diff --git a/tests/src/com/vaadin/tests/components/select/NativeSelects.java b/tests/src/com/vaadin/tests/components/select/NativeSelects.java
index cd2c95d127..8f3b79af21 100644
--- a/tests/src/com/vaadin/tests/components/select/NativeSelects.java
+++ b/tests/src/com/vaadin/tests/components/select/NativeSelects.java
@@ -143,10 +143,10 @@ public class NativeSelects extends ComponentTestCase<NativeSelect> {
                     }
                 });
 
-        errorIndicators.setValue(new Boolean(false));
-        readonly.setValue(new Boolean(false));
-        enabled.setValue(new Boolean(true));
-        nullSelect.setValue(new Boolean(false));
+        errorIndicators.setValue(Boolean.FALSE);
+        readonly.setValue(Boolean.FALSE);
+        enabled.setValue(Boolean.TRUE);
+        nullSelect.setValue(Boolean.FALSE);
 
         errorIndicators.setImmediate(true);
         readonly.setImmediate(true);
diff --git a/tests/src/com/vaadin/tests/components/textfield/TextFields.java b/tests/src/com/vaadin/tests/components/textfield/TextFields.java
index a908dccc1d..16ac819718 100644
--- a/tests/src/com/vaadin/tests/components/textfield/TextFields.java
+++ b/tests/src/com/vaadin/tests/components/textfield/TextFields.java
@@ -117,10 +117,10 @@ public class TextFields extends ComponentTestCase<TextField> {
                     }
                 });
 
-        errorIndicators.setValue(new Boolean(false));
-        required.setValue(new Boolean(false));
-        readonly.setValue(new Boolean(false));
-        enabled.setValue(new Boolean(true));
+        errorIndicators.setValue(Boolean.FALSE);
+        required.setValue(Boolean.FALSE);
+        readonly.setValue(Boolean.FALSE);
+        enabled.setValue(Boolean.TRUE);
 
         errorIndicators.setImmediate(true);
         required.setImmediate(true);
diff --git a/tests/src/com/vaadin/tests/featurebrowser/PropertyPanel.java b/tests/src/com/vaadin/tests/featurebrowser/PropertyPanel.java
index 5e105dbf1e..6a87dec748 100644
--- a/tests/src/com/vaadin/tests/featurebrowser/PropertyPanel.java
+++ b/tests/src/com/vaadin/tests/featurebrowser/PropertyPanel.java
@@ -272,8 +272,8 @@ public class PropertyPanel extends Panel implements Button.ClickListener,
 
         // Customization for Window component
         if (objectToConfigure instanceof Window) {
-            disableField(set.getField("enabled"), new Boolean(true));
-            disableField(set.getField("visible"), new Boolean(true));
+            disableField(set.getField("enabled"), Boolean.TRUE);
+            disableField(set.getField("visible"), Boolean.TRUE);
             disableField(set.getField("componentError"));
             disableField(set.getField("icon"));
         }
-- 
2.39.5