From 41e35c243b7cd58b68d4273c7d7f77ff88d32583 Mon Sep 17 00:00:00 2001
From: Stas Vilchik <vilchiks@gmail.com>
Date: Tue, 11 Feb 2014 18:13:36 +0600
Subject: [PATCH] SONAR-5052 Rework widgets drag'n'drop

Add an ability to move a widget below the lowest widget
---
 .../webapp/WEB-INF/app/views/dashboard/configure.html.erb     | 3 +--
 sonar-server/src/main/webapp/javascripts/dashboard.js         | 1 +
 sonar-server/src/main/webapp/stylesheets/dashboard.css        | 4 ++--
 3 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/sonar-server/src/main/webapp/WEB-INF/app/views/dashboard/configure.html.erb b/sonar-server/src/main/webapp/WEB-INF/app/views/dashboard/configure.html.erb
index c90aeae3a09..c7e410e5648 100644
--- a/sonar-server/src/main/webapp/WEB-INF/app/views/dashboard/configure.html.erb
+++ b/sonar-server/src/main/webapp/WEB-INF/app/views/dashboard/configure.html.erb
@@ -26,8 +26,6 @@
   %>
     <div class="dashboard-column-wrapper" style="width: <%= columns[index-1] -%>;margin: 0 -1px 0 0;">
       <div class="dashboard-column" id="dashboard-column-<%= index -%>" style="margin: 0 <%= index<columns.size() ? "5px" : "0px" -%> 0 <%= index>1 ? "5px" : "0px" -%>;">
-        <div class="column-handle" style="display: none"></div>
-
         <%
            @dashboard.widgets.select { |widget| widget.column_index==index && widget.java_definition }.sort_by { |widget| widget.row_index }.each do |widget|
         %>
@@ -37,6 +35,7 @@
         <%
            end
         %>
+        <div class="column-handle" style="display: none"></div>
       </div>
     </div>
   <% end %>
diff --git a/sonar-server/src/main/webapp/javascripts/dashboard.js b/sonar-server/src/main/webapp/javascripts/dashboard.js
index cc70df9bf8a..576dba7046d 100644
--- a/sonar-server/src/main/webapp/javascripts/dashboard.js
+++ b/sonar-server/src/main/webapp/javascripts/dashboard.js
@@ -39,6 +39,7 @@
           .on('dragstart', function(e) {
             e.originalEvent.dataTransfer.setData('text/plain', 'drag');
             draggable = $(this);
+            columnHandle.show();
           })
           .on('dragover', function(e) {
             if (draggable.prop('id') !== $(this).prop('id')) {
diff --git a/sonar-server/src/main/webapp/stylesheets/dashboard.css b/sonar-server/src/main/webapp/stylesheets/dashboard.css
index 2b996e164e7..710d6bb7fe2 100644
--- a/sonar-server/src/main/webapp/stylesheets/dashboard.css
+++ b/sonar-server/src/main/webapp/stylesheets/dashboard.css
@@ -209,7 +209,7 @@
 }
 
 #dashboard .column-handle {
-  height: 100px;
+  height: 30px;
   width: 100%;
   margin: 0;
   padding: 0;
@@ -218,7 +218,7 @@
   text-align: center;
   font-size: x-large;
   vertical-align: middle;
-  color: #555;
+  background-color: #eee;
 }
 
 #dashboard .block {
-- 
2.39.5