From 41e7210210b5e50bf57bbcf41259a4d343bba1f0 Mon Sep 17 00:00:00 2001 From: Jean-Philippe Lang Date: Tue, 29 Jul 2014 17:49:53 +0000 Subject: [PATCH] Fixed an error when member's project is nil (#17486). git-svn-id: http://svn.redmine.org/redmine/trunk@13334 e93f8b46-1217-0410-a6f0-8f06a7374b81 --- app/models/member.rb | 4 ++-- test/unit/member_test.rb | 10 ++++++++++ 2 files changed, 12 insertions(+), 2 deletions(-) diff --git a/app/models/member.rb b/app/models/member.rb index 547fa9eaa..aa1d50cdf 100644 --- a/app/models/member.rb +++ b/app/models/member.rb @@ -94,9 +94,9 @@ class Member < ActiveRecord::Base end def set_issue_category_nil - if user + if user_id && project_id # remove category based auto assignments for this member - IssueCategory.where(["project_id = ? AND assigned_to_id = ?", project.id, user.id]). + IssueCategory.where(["project_id = ? AND assigned_to_id = ?", project_id, user_id]). update_all("assigned_to_id = NULL") end end diff --git a/test/unit/member_test.rb b/test/unit/member_test.rb index 6ba9717c4..124aa3719 100644 --- a/test/unit/member_test.rb +++ b/test/unit/member_test.rb @@ -94,6 +94,16 @@ class MemberTest < ActiveSupport::TestCase assert !member.save end + def test_set_issue_category_nil_should_handle_nil_values + m = Member.new + assert_nil m.user + assert_nil m.project + + assert_nothing_raised do + m.set_issue_category_nil + end + end + def test_destroy category1 = IssueCategory.find(1) assert_equal @jsmith.user.id, category1.assigned_to_id -- 2.39.5