From 48e045181a8cf4aaeb237734390cf23962350222 Mon Sep 17 00:00:00 2001 From: Pascal Mugnier Date: Tue, 8 May 2018 11:45:36 +0200 Subject: [PATCH] Fix reset button on navbar searchbox not working with less then 2 chars --- .../ProjectActivityDateInput-test.js.snap | 21 +++++++++++++++---- .../main/js/components/controls/SearchBox.tsx | 2 +- 2 files changed, 18 insertions(+), 5 deletions(-) diff --git a/server/sonar-web/src/main/js/apps/projectActivity/components/__tests__/__snapshots__/ProjectActivityDateInput-test.js.snap b/server/sonar-web/src/main/js/apps/projectActivity/components/__tests__/__snapshots__/ProjectActivityDateInput-test.js.snap index 74e05f0bbf6..d10a64ba95c 100644 --- a/server/sonar-web/src/main/js/apps/projectActivity/components/__tests__/__snapshots__/ProjectActivityDateInput-test.js.snap +++ b/server/sonar-web/src/main/js/apps/projectActivity/components/__tests__/__snapshots__/ProjectActivityDateInput-test.js.snap @@ -1,8 +1,21 @@ -// Jest Snapshot v1, https://goo.gl/fbAQLP exports[`should render correctly the date inputs 1`] = ` +// Jest Snapshot v1, https://goo.gl/fbAQLP + +exports[`should render correctly the date inputs 1`] = `
- -
diff --git a/server/sonar-web/src/main/js/components/controls/SearchBox.tsx b/server/sonar-web/src/main/js/components/controls/SearchBox.tsx index 84329946fed..09b7c0a8074 100644 --- a/server/sonar-web/src/main/js/components/controls/SearchBox.tsx +++ b/server/sonar-web/src/main/js/components/controls/SearchBox.tsx @@ -105,7 +105,7 @@ export default class SearchBox extends React.PureComponent { handleResetClick = () => { this.changeValue('', false); - if (this.props.value === undefined) { + if (this.props.value === undefined || this.props.value === '') { this.setState({ value: '' }); } if (this.input) { -- 2.39.5