From 4ba99ae3f7448ce9c455aa668e5a5a5e655494c1 Mon Sep 17 00:00:00 2001 From: Adam Tkac Date: Tue, 10 May 2011 08:53:38 +0000 Subject: [PATCH] [Security] vncviewer can send password without proper validation of X.509 certs (CVE-2011-1775). Reference: http://www.mail-archive.com/tigervnc-devel@lists.sourceforge.net/msg01342.html git-svn-id: svn://svn.code.sf.net/p/tigervnc/code/branches/1_1@4400 3789f03b-4d11-0410-bbf8-ca57d06f2519 --- common/rfb/CSecurityTLS.cxx | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/common/rfb/CSecurityTLS.cxx b/common/rfb/CSecurityTLS.cxx index 6028792b..3421de5e 100644 --- a/common/rfb/CSecurityTLS.cxx +++ b/common/rfb/CSecurityTLS.cxx @@ -171,8 +171,15 @@ bool CSecurityTLS::processMsg(CConnection* cc) if (!is->checkNoWait(1)) return false; - if (is->readU8() == 0) - return true; + if (is->readU8() == 0) { + rdr::U32 result = is->readU32(); + CharArray reason; + if (result == secResultFailed || result == secResultTooMany) + reason.buf = is->readString(); + else + reason.buf = strDup("Authentication failure (protocol error)"); + throw AuthFailureException(reason.buf); + } if (gnutls_init(&session, GNUTLS_CLIENT) != GNUTLS_E_SUCCESS) throw AuthFailureException("gnutls_init failed"); -- 2.39.5