From 4be0942af0d0a73541148899fbb2e0c406795c79 Mon Sep 17 00:00:00 2001 From: kobrigo Date: Wed, 16 Jun 2010 04:38:19 -0700 Subject: [PATCH] argument shifting is not done correctly when the options argument is not supplied. the result is that the callback is not called. this fixes Ticket #5731 foooo --- ui/jquery.effects.core.js | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/ui/jquery.effects.core.js b/ui/jquery.effects.core.js index f4fca9f93..801b57e4c 100644 --- a/ui/jquery.effects.core.js +++ b/ui/jquery.effects.core.js @@ -418,15 +418,15 @@ function _normalizeArguments(effect, options, speed, callback) { speed = null; options = {}; } - if ($.isFunction(speed)) { - callback = speed; - speed = null; - } - if (typeof options == 'number' || $.fx.speeds[options]) { + if (typeof options == 'number' || $.fx.speeds[options]) { callback = speed; speed = options; options = {}; } + if ($.isFunction(speed)) { + callback = speed; + speed = null; + } options = options || {}; -- 2.39.5