From 4d13aefd6eb475a5726e1d53cd365f620253a26f Mon Sep 17 00:00:00 2001 From: Dominik Stadler Date: Sat, 4 Nov 2017 13:45:12 +0000 Subject: [PATCH] Add test-case which shows that bug 55814 is fixed already by other changes git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1814290 13f79535-47bb-0310-9956-ffa450edef68 --- .../poi/xssf/usermodel/TestXSSFComment.java | 33 ++++++++++++++++++ test-data/spreadsheet/55814.xlsx | Bin 0 -> 9286 bytes 2 files changed, 33 insertions(+) create mode 100644 test-data/spreadsheet/55814.xlsx diff --git a/src/ooxml/testcases/org/apache/poi/xssf/usermodel/TestXSSFComment.java b/src/ooxml/testcases/org/apache/poi/xssf/usermodel/TestXSSFComment.java index fd153a77af..e1afacbc55 100644 --- a/src/ooxml/testcases/org/apache/poi/xssf/usermodel/TestXSSFComment.java +++ b/src/ooxml/testcases/org/apache/poi/xssf/usermodel/TestXSSFComment.java @@ -313,6 +313,39 @@ public final class TestXSSFComment extends BaseTestCellComment { } } + @Test + public void testBug55814() throws IOException { + try (Workbook wb = XSSFTestDataSamples.openSampleWorkbook("55814.xlsx")) { + + int oldsheetIndex = wb.getSheetIndex("example"); + Sheet oldsheet = wb.getSheetAt(oldsheetIndex); + + Comment comment = oldsheet.getRow(0).getCell(0).getCellComment(); + assertEquals("Comment Here\n", comment.getString().getString()); + + Sheet newsheet = wb.cloneSheet(oldsheetIndex); + + wb.removeSheetAt(oldsheetIndex); + + //wb.write(new FileOutputStream("/tmp/outnocomment.xlsx")); + + comment = newsheet.getRow(0).getCell(0).getCellComment(); + assertNotNull("Should have a comment on A1 in the new sheet", comment); + assertEquals("Comment Here\n", comment.getString().getString()); + + Workbook wbBack = XSSFTestDataSamples.writeOutAndReadBack(wb); + assertNotNull(wbBack); + wbBack.close(); + } + + try (Workbook wb = XSSFTestDataSamples.openSampleWorkbook("55814.xlsx")) { + int oldsheetIndex = wb.getSheetIndex("example"); + Sheet newsheet = wb.getSheetAt(oldsheetIndex); + Comment comment = newsheet.getRow(0).getCell(0).getCellComment(); + assertEquals("Comment Here\n", comment.getString().getString()); + } + } + @Test public void bug57838DeleteRowsWthCommentsBug() throws IOException { Workbook wb = XSSFTestDataSamples.openSampleWorkbook("57838.xlsx"); diff --git a/test-data/spreadsheet/55814.xlsx b/test-data/spreadsheet/55814.xlsx new file mode 100644 index 0000000000000000000000000000000000000000..ae6d9eccdd38000b7cfc4f9c934bd54648a44c81 GIT binary patch literal 9286 zcmeHNg1 zlXi4)Gk0(^()4yRcQs)5vbUqmL%hS73%CRS{r|TA;uR=M>U-3|i6eU=cPYKhrtqZ( zjKa4a*pA1nCf?ea*!{}rpuV!jGGP==HKW)@pc>D2=N-@eA*&ibVTd$%#cnX<^D{bQ zbcSSu-TODandF#rAexu{hU>@?NaU0IL0&KU-)i(66pvyc@<3eg|P z_+X;%$W{}eFPsFm0XedwjZH~xG5JBtFaj3x#8fu_IT6&{c)FpBAU+n$cHeR|++HRl zy|dVaYaH$fyFueZ(YbicZaviRgVwDZ_3oDXkzCp-uK*hn$*=;Rh#aJ9*qu+^b0x=; z@^Ti`odPC|D$NsqOYH}J@60E+YjQ%wpT+4Q$mG{r3`D6OtEOQ+aV7Sy#i+C^7_7wI z*~cw`Jrfw}W8>u(14oHqdac-<bAIS6;x<Zf<}8 z)xUY|o5!3q-{GdH1b0ewxYruFnA^E>u>Uyz&s+bCUGy(gk4hMVdn-owuH1X+<%>-R zITTo7qmo=Bl_sc_c8B6kbUrQk(uQ zWaCwyqlKLdrM9#t=pl(AGtr)%vorE4NXmqMx+t!Rj3jADx}<^flB*D)?{B#j#&fED zG_e{>^sMGBud<^T$ErUx^-&Z!8(*Z)V@28m zy<}*nI76yWKIq;nP(3x5>d{}PbP;@@R75wd60DF#A$!XJ| z=;F)ZugYepCT(5Vnnv)6|L!FL;z_AT@R0_%myiHZ5WMU-{%{meM;BYDqoeJQ?Dj9G zL4ci8hz9mWhnhIjtv#7>h1eS~-*|8FfTSm*fVnrv*eGxlU#0pj+UVR| zpjA;?;>`(`{S2ue+N!_IkR>(kKJPMe*n^i?khWNMZki8=`+!)|C^H*z$ivM>G3|bKz$XAvrrBBA8Y>;GCXyo57sNPJq3oUp$M62etr6c5N z;m3XA)A%i!HfP~IXG3l;brGVQdHwKOU^7Mb?hey_fc0R(i0UwlR|AWqW8DkqRBTgr zM1*Og*Qjj{c^|Yf8CQwA1G^vDXF(APMIO!x8-Ec1NcJ*DFNvxvSqbCv??_;1e98-a zsPP8PEsYY37QMdNG5GuIFOyR3&Mq=(Zz`3(&NUUta8qR0qqL%Dz<9|ond&FSUrRwf zo1#*AnOl^bh1y{jg+DgG-47r870CwQR>B zhoxyQoj-u|?!$%LMZNQ%V8b4i!^)ls?83rUjg6;}7eajmK>=C< zxq?&cMV!Q5Vohb)V0qYrRZIY;KE(Kwn7Cc6s78q*_ak}DLPRdkl!R>Du9z)(HzhKg z(Vnf6aenNy56vU3^$r=BtMeG^gi7vCNC$1@k}oPs46ifEFP_xAk3F7sW%PWM8+}bE zZ>|oiCmufco!Z<)^D@f6Qi-n3IY}4aj3uJpv86vveA_T7z@UHGc!Bs&%W?rNv`>Pg zo0p_NDvzI@=4NGXZ_e@a_;W3`AS#YC`~)r7Q=XJ=j`j?7q{!|OQ`MQ}%A}nRp&;w@ z6djE`@Tj~$>GaYwgpLN2RD{NDPCJ(2JB@BR^m?J?!1H^@atbxXeTt(~e&GSpA~ zZswP0+`mr;g~6n$X;++QN)0M}!aBt%#ssZ=JwvV(NkIu{J*NF$O4D;$a=X)$7rO>s znas4fl2zgR(caW%W|P$0~PJ)V3uVL{iuhgJlH&A;MgZax*_l>}Pw}Cx^HbzU`Z=dwEJzUO_TF1F7K7Did zeUp`qU_6hkT+S++@%{QidEyA`v#llWZHG5%<&CFzuD;Wy>%DmNazw$rS_boj_+;uH z>4b&9??4-AT$ez~-uFR|w=-^gNM`#3bbdDqr4Y}3Bm!;{mDJ&B*wqsSu}~$!8Mfz+ z0Kfc{sIqr1wQGZ&m~ak%I{mDx{kHqSJUHqR25LWg1~uH7!zNA^1?*w`$;vd081wx`ZN zIbQojkuQ<`&e5LQ;C)7*Va}|l z8F?_Y$O?6h)MOcOB4|m@u7K$zeaNiiB^VjxvI^DeBsccc>28cP?RnD#x$~F@U7_cA zHck+_!$ZbG7MI3Yuy&dhhqt|>wmIbjutt26p1Ofi z;bB+nN#ribGUgLX)*vT`(ytIqfw!8rFPzOpmK;yE7EU=rh74cA=i9QBIk_GqDKu!5 z(2(31e6}FitXtWuuzTBNKh^m$!SY0=+VJ@WcFH=rXygg1S=RyK_X??&(&0HhBbfHe zLD#1hS*8%?a#Fk*+sr``-OpYsjHW<7%jF{8rnkYER$oFTn+C~*<)7dvN_mZ^V_=Z! zQ&vHO5Va}P?qNw~f#(emdE>!F1;B7T_OI`)LKLlSMUSpOX7iJtlR;TRJ8fcPxAz)A zgE6E+_h}v*55B&i@2lU)%CK8_qO6 zd|^_=D;%A7s69^xNCrjH;;ZW#zpJehEH2};=NpI8};d7+W`+3c)6vs{Tw0M*9n!eqO-ph^Q7k7@!d1%`>qlNoFs0$vn}pVA?do z$Q|wXoS2e#J;zsDC_~R%280wl3iz^UClD~>a;qpxRB>vs&3k3$nL2GY=FH`5lH$UP z1M9h~p|KyROr#BfnLdsuswgmrSMs_@7&~T{?{=+`qVLQu6C4hdn4Qhpx-R7G_}Os> zsXLJKV=7zR=y$#s)7g6E(FDofZjzNf>dYH>WeGv(N7IvJQNH*@@HI=Xyj(|-q>_*O zYind5Nr&+q4xLkc@Dat-P4Qm()dEaloJ!)^bi~5Nb9y8bpqhU#KS+*9PDC)UyBBNP zc(kC*dTdf&k8P%mqke4QESs|~WsCJ%{AKmwYQOo~@}ew>$eSutTamia@rBQcOlZ=H zTa>0`rp-zBBrNtv{GE=l{P@$j=#)9zUNQ&3LP2Sw&z9ek4UCqzz*E%kxgD7*_s|Ls z6(!;H8Rj2J%+<}?&ip4{DM(U`o#w=OwwruT!8#uVe9o3j%YqR3dbCa#mHE339&*`t znwl5(qpxn7mIT4;AYE&YUN4J-fes$|9a5%Y7M>K_ATQOAk-4 zpj1(T>CMq-z(Y64K~~d%izFeU97Nq_h4rI*xqbx0vt!&84uu<4J;y+#V?zk^X`VJS zn5Uao(S_}`B$hBR+?_<04jp96eA?!;tEJv6OFE8Uxt{U)LLRHon{MAb*sj8v@Dr#0 zy)qNoh_$D((_@J#uU$peOuueQMF6dO>Hup}7z&sXtN|$^7UP6v#i=LuclnsoVxA$4 zNi@ZV)GhVe?ICR3vFMe|yi>IQ#cX~k_ak1L0`dgu6VbD`WA{X{r-kYpSeXRHY-I0- zEnmuVfQ5wcp=%7szTO=U3I#Url6P>Y@7C^$_!7e63^Cq2?Ojr_Rn14sDtq@KFH&x2 z7I1uxr^q9C`kjT|n9LVZcwAqw!Xd!mtd%vx79IK&I9RDzl|6&?f>B4__Ukc`X+-4# zk=CAWJJONi(Bc84O7uBu#-#kfP+$S&t{=au6A0?z2J1;J>Dtpt(e z*2;Y9)jz_`lRIljbMTQ~AOJx88{GT_G@}yx9AAUCHh$py(yw)U=>Z;=?o3a6U zl~-wG^1)}S^3yRl%`{Bh`hw^jh#0a5{Y}f}-;bb}Gp1qFjTuCc!TZ7+$sPs+Pj7sh z&pIJW3k1ZwRjUu9E=#;`Duhp~qQ#(48K>%1e+6kKnItjYuyl&y5v6ZI&t*D>!vzr$ z`Rr>Rd|5qvXd)>hj{ngKv*T@fO8tS0=4%F4)Wp72ud z)lQZj_9F;eP;9eu`jJ-uD7%4pM9+<%t~Y|uQWb0PwnIJD9(a|1dfhE+%f-U{-A)#E z6_*@FW4*(nyF|)-1~U}VpQ81%CUqXgsRclXgrG!7r{gL}_K+=*>%s2+(8ek+_mOe)w7V6ro@9L0Wm z8qx3#pRbwWW{E3lv%Z~?>HfHIW0M4`kz`;I+I1`Ay#gLAPK!Fmk|(~F8okbJ>6VC* z%ck?o$y15E@)R(_cpl$pSS^z4uOs`7MNlb2O|;T1H5nwLYCv+^-7lB7xi>c;lze@) z*jaDpUYdhLp;bU{KTI0*LM=XQTfW(FL9zB#ihm4KXd+(A3h*#x0Y~C+xc#H5HFGiX z{83nOc-Y&?{Bh024!@4lY=fHxMicgw1j;5=YC(0A`IM#zcm(#=zLnp&N2)qaCz_Rn za7p;;T&-@5w}Z1k%rxE4XVI57>*Ni--$ibN6iByH3L;tFkymFPiSYI{W3`sS_VSDX zKHkmq&h5#R-0mK4l^Y7*T#mM0zMRB-v}A|Y4H}S~8=4O@EwQ4s@M?L9yK6k|gG6>S z=2T$UL7?diPZ~OMQk+SG1DMLGPcCb30VA#+{uU1bx1t1Xuit5Epb&|;5VW3k#Of6q zWN0?c@nIP$g_u&;zWn$isFOyQVtqaBO&#L4PWpm6b^O$uX`MY@xh{VyCXi0viK=>8 zZ5&(WBOgOlFSSEmdAUS8x~}^DO{qDZ&ayV+-aKs|{9$qwhrD9lw<6z&u<8o5aw=*c zOABa3RjF;bV~9eelNAzU-&eHmyy7|bHfahlEClLV2F>bNZWJ@yVw|Q=>8>fbO%Wd0 z^br-PG3Ws`^G%Y^!KaG`GOiND*)R5`74x09lG_*po;cY;X9W#*(p~XCN~3?7>8&Mt zdE+#ZAL_~x7HS*Rl&16w$Q~8lU8{k!=I7Cmit5*2DiX znxgEtg^@Re`l<_wa@^TydN65}6zEnL0`CdLE{%Ayd`z@6f5x=0OJp9%e&83*hsf@| zP>)>XL7j)o)D`@iqT)V4-Pj5ogbGTGTG({}yu8XG3Nf1;XU?+AvL1g?TPPT+aj`z3 zxz)h_jWFoJ5yPqb#U5`|2J_gi0swmTgk-0KzoJHq(osbTvG|*yP54vG!YJ#bqILvq z%EVKU*o;9!YS-+QLy%5oFX6{f^2Kt0{+3;kK3l-*Ns3cczZ^_VBi*>rY-mGj6~J&W-o%1~mnZ_`BD1tSe-x zBbf)0d#r=Nv&C`W*P|*qUCswh_nDlDf`a@~17NCM4d~j)IjM&o zAPn>nk_+MwZ30|meHV>+5pxlI(?57LEc2jXe8Fq14ibtiGw&4TZiz@ zlVh&F?6MwqFk~V1HP`+CBMYpEs;#{u{=kB<=DYu{&ULW-xS-&QvDS6DN1U|*OdeLS zD=l%&MRSam-8Pu+uT+H2r(AF(p7UaZEU0Yw?##L~m7bDPrf=Jp`lHnWY*FJv%aMt+ zQ90G-GEc6`B)K6ocR=aDws7QZw{}m9tV2ZKKlA0HJbGOz@Fk;yBL|$nx~Peh)Bija zZbyG^SqVQ=WXLY?7%OBaI;(;>1gynXKq{Quaffz$FiWXN%3K}?Li2e{r7pgE!(%#n zS>^IvMtv3}tbLUB0m&$QC6C~)55CQ}lVqg1l06( za)seHtUZ=vW%i0=^4TXj#K)fS9L)DotEQq3nSYo1xopq2%fq*80yA7$n7XZj@r3iFTgt^Un3$%;F_@xO4 z^|#K%ZQ=6`Q1 zxLs}kQXm0mkl|1CtM-w)pJ?_e;S9+0W