From 4d6b4536b2e0148d4b228884a0b356e73dd8beec Mon Sep 17 00:00:00 2001 From: Timmy Willison <4timmywil@gmail.com> Date: Mon, 20 Mar 2017 12:24:49 -0400 Subject: [PATCH] Revert "Event: Trigger checkbox and radio click events identically" This reverts commit b442abacbb8464f0165059e8da734e3143d0721f. --- src/event.js | 10 +++------- src/manipulation.js | 6 +++--- src/{ => manipulation}/var/rcheckableType.js | 0 src/serialize.js | 2 +- 4 files changed, 7 insertions(+), 11 deletions(-) rename src/{ => manipulation}/var/rcheckableType.js (100%) diff --git a/src/event.js b/src/event.js index e9c223448..071deb645 100644 --- a/src/event.js +++ b/src/event.js @@ -3,15 +3,13 @@ define( [ "./var/document", "./var/documentElement", "./var/rnothtmlwhite", - "./var/rcheckableType", "./var/slice", "./data/var/dataPriv", "./core/nodeName", "./core/init", "./selector" -], function( jQuery, document, documentElement, rnothtmlwhite, - rcheckableType, slice, dataPriv, nodeName ) { +], function( jQuery, document, documentElement, rnothtmlwhite, slice, dataPriv, nodeName ) { "use strict"; @@ -477,11 +475,9 @@ jQuery.event = { }, click: { - // For checkable types, fire native event so checked state will be right + // For checkbox, fire native event so checked state will be right trigger: function() { - if ( rcheckableType.test( this.type ) && - this.click && nodeName( this, "input" ) ) { - + if ( this.type === "checkbox" && this.click && nodeName( this, "input" ) ) { this.click(); return false; } diff --git a/src/manipulation.js b/src/manipulation.js index eebcd138e..cd225a6db 100644 --- a/src/manipulation.js +++ b/src/manipulation.js @@ -2,8 +2,8 @@ define( [ "./core", "./var/concat", "./var/push", - "./var/rcheckableType", "./core/access", + "./manipulation/var/rcheckableType", "./manipulation/var/rtagName", "./manipulation/var/rscriptType", "./manipulation/wrapMap", @@ -22,8 +22,8 @@ define( [ "./traversing", "./selector", "./event" -], function( jQuery, concat, push, rcheckableType, - access, rtagName, rscriptType, +], function( jQuery, concat, push, access, + rcheckableType, rtagName, rscriptType, wrapMap, getAll, setGlobalEval, buildFragment, support, dataPriv, dataUser, acceptData, DOMEval, nodeName ) { diff --git a/src/var/rcheckableType.js b/src/manipulation/var/rcheckableType.js similarity index 100% rename from src/var/rcheckableType.js rename to src/manipulation/var/rcheckableType.js diff --git a/src/serialize.js b/src/serialize.js index 4008093c5..2e28ce1e0 100644 --- a/src/serialize.js +++ b/src/serialize.js @@ -1,6 +1,6 @@ define( [ "./core", - "./var/rcheckableType", + "./manipulation/var/rcheckableType", "./core/init", "./traversing", // filter "./attributes/prop" -- 2.39.5