From 5105c84b6310750a73e5ad46ac0fda03e35b0720 Mon Sep 17 00:00:00 2001 From: Julien Lancelot Date: Thu, 12 Jun 2014 11:58:29 +0200 Subject: [PATCH] SONAR-5351 Create a migration to replace rules.parent_id to rules.template_id --- .../shared.xml | 4 +- ...rmanentIdFromReferenceViolation-result.xml | 4 +- .../shouldSaveViolations-result.xml | 4 +- .../sonar/batch/rule/ActiveRulesProvider.java | 5 +- .../PastMeasuresLoaderTest/shared.xml | 4 +- .../UpdateStatusJobTest/sharedFixture.xml | 2 +- .../core/persistence/DatabaseVersion.java | 2 +- .../java/org/sonar/core/rule/RuleDto.java | 10 ++-- .../org/sonar/core/persistence/rows-h2.sql | 1 + .../org/sonar/core/persistence/schema-h2.ddl | 2 +- .../org/sonar/core/rule/RuleMapper.xml | 10 ++-- .../core/rule/CacheRuleFinderTest/shared.xml | 8 ++-- .../rule/DefaultRuleFinderTest/shared.xml | 8 ++-- .../core/rule/RuleDaoTest/insert-result.xml | 2 +- .../rule/RuleDaoTest/insert_all-result.xml | 4 +- .../core/rule/RuleDaoTest/update-result.xml | 6 +-- .../sonar/core/rule/RuleDaoTest/update.xml | 2 +- ...umberOfRulesOfACategoryForGivenPlugins.xml | 8 ++-- ...uleParametersFromARuleParameter-result.xml | 2 +- ...ActiveRuleParametersFromARuleParameter.xml | 2 +- .../shouldDeleteActiveRules-result.xml | 6 +-- .../RulesDaoTest/shouldDeleteActiveRules.xml | 6 +-- .../dao/RulesDaoTest/shouldGetActiveRules.xml | 6 +-- .../dao/RulesDaoTest/shouldGetRuleParams.xml | 4 +- .../shouldGetRuleWithRuleKeyAndPluginKey.xml | 2 +- .../jpa/dao/RulesDaoTest/shouldGetRules.xml | 4 +- .../checks/AnnotationCheckFactoryTest.java | 6 +-- .../main/java/org/sonar/api/rules/Rule.java | 47 ++++++++++++------- .../sonar/server/debt/DebtModelBackup.java | 5 +- .../server/qualityprofile/RuleActivator.java | 9 ++-- .../org/sonar/server/rule/RegisterRules.java | 28 +++++------ .../org/sonar/server/rule/RuleCreator.java | 2 +- .../org/sonar/server/rule/RuleDeleter.java | 2 +- .../org/sonar/server/rule/db/RuleDao.java | 7 +-- .../server/rule/index/RuleNormalizer.java | 13 ++--- .../538_add_dates_to_active_rules_table.rb | 1 + .../migrate/539_insert_active_rule_dates.rb | 1 + .../db/migrate/540_create_log_table.rb | 5 ++ ...541_add_unique_index_on_active_rule_key.rb | 5 ++ ..._add_index_on_snapshot_data_resource_id.rb | 5 ++ .../db/migrate/543_add_type_to_log_table.rb | 5 ++ ...4_rename_rules_parent_id_to_template_id.rb | 33 +++++++++++++ .../server/debt/DebtModelBackupTest.java | 11 +---- .../server/rule/RuleCreatorMediumTest.java | 2 +- .../org/sonar/server/rule/RuleTesting.java | 2 +- .../org/sonar/server/rule/db/RuleDaoTest.java | 8 ++-- .../rule/index/RuleIndexMediumTest.java | 13 ++--- .../server/rule/ws/RulesWebServiceTest.java | 4 +- ...e_deprecated_active_rule_params-result.xml | 4 +- .../disable_deprecated_active_rule_params.xml | 2 +- ...disable_deprecated_active_rules-result.xml | 8 ++-- .../disable_deprecated_active_rules.xml | 4 +- ...disable_deprecated_repositories-result.xml | 6 +-- .../disable_deprecated_rules-result.xml | 8 ++-- .../disable_deprecated_rules.xml | 4 +- ...ate_rules_if_parent_is_disabled-result.xml | 12 ++--- ...e_template_rules_if_parent_is_disabled.xml | 8 ++-- ..._rule_is_linked_on_root_characteristic.xml | 4 +- .../insert_extended_repositories-result.xml | 4 +- .../insert_new_rules-result.xml | 6 +-- ..._disable_already_disabled_rules-result.xml | 8 ++-- .../not_disable_already_disabled_rules.xml | 4 +- .../not_disable_manual_rules-result.xml | 8 ++-- .../not_disable_manual_rules.xml | 4 +- ...late_rules_if_parent_is_enabled-result.xml | 6 +-- ...le_template_rules_if_parent_is_enabled.xml | 4 +- ...t_update_already_disabled_rules-result.xml | 4 +- .../not_update_already_disabled_rules.xml | 2 +- ...ules_when_repository_is_still_existing.xml | 2 +- .../reactivate_disabled_rules-result.xml | 4 +- .../reactivate_disabled_rules.xml | 2 +- ...ctivate_disabled_template_rules-result.xml | 6 +-- .../reactivate_disabled_template_rules.xml | 4 +- ...c_when_characteristic_not_found-result.xml | 4 +- ...teristic_when_characteristic_not_found.xml | 4 +- ...rriding_characteristic_disabled-result.xml | 4 +- ...and_overriding_characteristic_disabled.xml | 4 +- ...racteristic_has_been_overridden-result.xml | 4 +- ...but_characteristic_has_been_overridden.xml | 4 +- .../server/rule/RegisterRulesTest/shared.xml | 2 +- ...ame_and_description_in_database-result.xml | 4 +- .../update_rule_fields-result.xml | 4 +- .../RegisterRulesTest/update_rule_fields.xml | 4 +- .../update_rule_parameters-result.xml | 4 +- .../update_rule_parameters.xml | 4 +- .../update_template_rule_language-result.xml | 8 ++-- .../update_template_rule_language.xml | 8 ++-- .../rule/db/RuleDaoTest/insert-result.xml | 2 +- .../rule/db/RuleDaoTest/insert_all-result.xml | 4 +- .../RuleDaoTest/insert_parameter-result.xml | 2 +- .../rule/db/RuleDaoTest/insert_parameter.xml | 2 +- .../rule/db/RuleDaoTest/update-result.xml | 6 +-- .../server/rule/db/RuleDaoTest/update.xml | 2 +- ...th_coeff_to_constant_issue_with_offset.xml | 6 +-- ...f_to_constant_issue_with_offset_result.xml | 6 +-- ...irements_from_characteristics_to_rules.xml | 18 +++---- ...s_from_characteristics_to_rules_result.xml | 18 +++---- .../do_nothing_when_already_executed.xml | 18 +++---- ...o_nothing_when_already_executed_result.xml | 18 +++---- 99 files changed, 334 insertions(+), 290 deletions(-) create mode 100644 sonar-server/src/main/webapp/WEB-INF/db/migrate/544_rename_rules_parent_id_to_template_id.rb diff --git a/plugins/sonar-core-plugin/src/test/resources/org/sonar/plugins/core/timemachine/ViolationPersisterDecoratorTest/shared.xml b/plugins/sonar-core-plugin/src/test/resources/org/sonar/plugins/core/timemachine/ViolationPersisterDecoratorTest/shared.xml index 4b0310365c9..57203056802 100644 --- a/plugins/sonar-core-plugin/src/test/resources/org/sonar/plugins/core/timemachine/ViolationPersisterDecoratorTest/shared.xml +++ b/plugins/sonar-core-plugin/src/test/resources/org/sonar/plugins/core/timemachine/ViolationPersisterDecoratorTest/shared.xml @@ -2,11 +2,11 @@ + cardinality="SINGLE" template_id="[null]"/> + cardinality="SINGLE" template_id="[null]"/> + cardinality="SINGLE" template_id="[null]"/> + cardinality="SINGLE" template_id="[null]"/> + cardinality="SINGLE" template_id="[null]"/> + cardinality="SINGLE" template_id="[null]"/> + cardinality="SINGLE" template_id="[null]"/> + cardinality="SINGLE" template_id="[null]"/> + plugin_name="maven-checkstyle-plugin" description="description" cardinality="SINGLE" template_id="[null]"/>