From 5280861cf309652d0ebf64658ef9cf2563ef8745 Mon Sep 17 00:00:00 2001 From: Toshi MARUYAMA Date: Thu, 22 Oct 2020 14:18:44 +0000 Subject: [PATCH] use with_settings at IssuesControllerTest#test_show_should_not_disclose_relations_to_invisible_issues git-svn-id: http://svn.redmine.org/redmine/trunk@20167 e93f8b46-1217-0410-a6f0-8f06a7374b81 --- test/functional/issues_controller_test.rb | 39 ++++++++++++----------- 1 file changed, 20 insertions(+), 19 deletions(-) diff --git a/test/functional/issues_controller_test.rb b/test/functional/issues_controller_test.rb index edf973e6a..27bf2f3f1 100644 --- a/test/functional/issues_controller_test.rb +++ b/test/functional/issues_controller_test.rb @@ -2261,25 +2261,26 @@ class IssuesControllerTest < Redmine::ControllerTest end def test_show_should_not_disclose_relations_to_invisible_issues - Setting.cross_project_issue_relations = '1' - IssueRelation. - create!( - :issue_from => Issue.find(1), - :issue_to => Issue.find(2), - :relation_type => 'relates' - ) - # Relation to a private project issue - IssueRelation. - create!( - :issue_from => Issue.find(1), - :issue_to => Issue.find(4), - :relation_type => 'relates' - ) - get(:show, :params => {:id => 1}) - assert_response :success - assert_select 'div#relations' do - assert_select 'a', :text => /#2$/ - assert_select 'a', :text => /#4$/, :count => 0 + with_settings :cross_project_issue_relations => '1' do + IssueRelation. + create!( + :issue_from => Issue.find(1), + :issue_to => Issue.find(2), + :relation_type => 'relates' + ) + # Relation to a private project issue + IssueRelation. + create!( + :issue_from => Issue.find(1), + :issue_to => Issue.find(4), + :relation_type => 'relates' + ) + get(:show, :params => {:id => 1}) + assert_response :success + assert_select 'div#relations' do + assert_select 'a', :text => /#2$/ + assert_select 'a', :text => /#4$/, :count => 0 + end end end -- 2.39.5