From 52ef7a985e2f96d0f6ea55ea7e14deae96e57e4d Mon Sep 17 00:00:00 2001 From: Artur Signell Date: Tue, 17 Apr 2012 22:04:27 +0300 Subject: [PATCH] Remove widget if it is still in the DOM when connector is unregistered --- .../gwt/client/ui/AbstractComponentConnector.java | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/src/com/vaadin/terminal/gwt/client/ui/AbstractComponentConnector.java b/src/com/vaadin/terminal/gwt/client/ui/AbstractComponentConnector.java index 2458a27eac..a56f5f5525 100644 --- a/src/com/vaadin/terminal/gwt/client/ui/AbstractComponentConnector.java +++ b/src/com/vaadin/terminal/gwt/client/ui/AbstractComponentConnector.java @@ -338,12 +338,13 @@ public abstract class AbstractComponentConnector extends AbstractConnector public void onUnregister() { super.onUnregister(); - // Warn if widget is still attached to DOM. It should never be at this - // point. + // Show an error if widget is still attached to DOM. It should never be + // at this point. if (getWidget() != null && getWidget().isAttached()) { - VConsole.log("Widget for unregistered connector " + getWidget().removeFromParent(); + VConsole.error("Widget is still attached to the DOM after the connector (" + Util.getConnectorString(this) - + " is still attached to the DOM."); + + ") has been unregistered. Widget was removed."); } } } -- 2.39.5