From 53d74a67fa4612fcc6b64b342c746a1fe11926ca Mon Sep 17 00:00:00 2001 From: Javen O'Neal Date: Wed, 19 Oct 2016 07:37:47 +0000 Subject: [PATCH] disabled unit tests are now passing for bug 48703 git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1765544 13f79535-47bb-0310-9956-ffa450edef68 --- .../org/apache/poi/xssf/usermodel/TestXSSFBugs.java | 2 -- src/testcases/org/apache/poi/hssf/usermodel/TestBugs.java | 5 ++--- 2 files changed, 2 insertions(+), 5 deletions(-) diff --git a/src/ooxml/testcases/org/apache/poi/xssf/usermodel/TestXSSFBugs.java b/src/ooxml/testcases/org/apache/poi/xssf/usermodel/TestXSSFBugs.java index 66b26d377c..d6d26943b1 100644 --- a/src/ooxml/testcases/org/apache/poi/xssf/usermodel/TestXSSFBugs.java +++ b/src/ooxml/testcases/org/apache/poi/xssf/usermodel/TestXSSFBugs.java @@ -1354,9 +1354,7 @@ public final class TestXSSFBugs extends BaseTestBugzillaIssues { /** * Sum across multiple workbooks * eg =SUM($Sheet1.C1:$Sheet4.C1) - * DISABLED As we can't currently evaluate these */ - @Ignore @Test public void bug48703() throws IOException { XSSFWorkbook wb = XSSFTestDataSamples.openSampleWorkbook("48703.xlsx"); diff --git a/src/testcases/org/apache/poi/hssf/usermodel/TestBugs.java b/src/testcases/org/apache/poi/hssf/usermodel/TestBugs.java index 65042127e8..454c1da683 100644 --- a/src/testcases/org/apache/poi/hssf/usermodel/TestBugs.java +++ b/src/testcases/org/apache/poi/hssf/usermodel/TestBugs.java @@ -2373,9 +2373,8 @@ public final class TestBugs extends BaseTestBugzillaIssues { /** * Sum across multiple workbooks * eg =SUM($Sheet2.A1:$Sheet3.A1) - * DISABLED - We currently get the formula wrong, and mis-evaluate */ - @Ignore + @Test public void test48703() throws Exception { HSSFWorkbook wb = openSample("48703.xls"); assertEquals(3, wb.getNumberOfSheets()); @@ -2385,7 +2384,7 @@ public final class TestBugs extends BaseTestBugzillaIssues { Row r = sheet.getRow(0); Cell c = r.getCell(0); - assertEquals("SUM(Sheet2!A1:Sheet3!A1)", c.getCellFormula()); + assertEquals("SUM(Sheet2:Sheet3!A1)", c.getCellFormula()); assertEquals(4.0, c.getNumericCellValue(), 0); // Check the evaluated result -- 2.39.5