From 5442f8efd6c9cb2b75ccc077bee9a619084194c7 Mon Sep 17 00:00:00 2001 From: =?utf8?q?Daniel=20Calvi=C3=B1o=20S=C3=A1nchez?= Date: Tue, 8 Nov 2022 00:27:15 +0100 Subject: [PATCH] Fix HTML entities not decoded in comment just added MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit The XML data received from the comments endpoint has an inconsistent encoding; some entities are encoded once and others are encoded twice. When the comment list is loaded the comments are fetched using GetComments, which handles all that, and therefore shows the messages and author names as expected. However, when a new comment is posted the list is not got again; instead the new comment is loaded from the comment data returned after posting it. This is done in NewComment, which did not decode the messages nor the author names, and therefore showed, for example, "&" instead of "&". To solve that now the same decoding logic used in GetComments is applied too in NewComment. Signed-off-by: Daniel Calviño Sánchez --- apps/comments/src/services/NewComment.js | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/apps/comments/src/services/NewComment.js b/apps/comments/src/services/NewComment.js index eaf08cc10b9..27d227ed656 100644 --- a/apps/comments/src/services/NewComment.js +++ b/apps/comments/src/services/NewComment.js @@ -22,6 +22,7 @@ import { getCurrentUser } from '@nextcloud/auth' import { getRootPath } from '../utils/davUtils' +import { decodeHtmlEntities } from '../utils/decodeHtmlEntities' import axios from '@nextcloud/axios' import client from './DavClient' @@ -55,5 +56,12 @@ export default async function(commentsType, ressourceId, message) { details: true, }) + const props = comment.data.props + // Decode twice to handle potentially double-encoded entities + // FIXME Remove this once https://github.com/nextcloud/server/issues/29306 + // is resolved + props.actorDisplayName = decodeHtmlEntities(props.actorDisplayName, 2) + props.message = decodeHtmlEntities(props.message, 2) + return comment.data } -- 2.39.5