From 5449ddfa363cfe06e5ad58a9c16d38f482f424c7 Mon Sep 17 00:00:00 2001
From: Julien Lancelot <julien.lancelot@gmail.com>
Date: Fri, 24 May 2013 14:57:14 +0200
Subject: [PATCH] SONAR-4301 Fix sql query

---
 .../main/java/org/sonar/core/issue/db/IssueDao.java |  4 ++--
 .../org/sonar/core/issue/db/IssueMapper.xml         | 13 +++++++++++--
 2 files changed, 13 insertions(+), 4 deletions(-)

diff --git a/sonar-core/src/main/java/org/sonar/core/issue/db/IssueDao.java b/sonar-core/src/main/java/org/sonar/core/issue/db/IssueDao.java
index 55f672c763c..9c46d100585 100644
--- a/sonar-core/src/main/java/org/sonar/core/issue/db/IssueDao.java
+++ b/sonar-core/src/main/java/org/sonar/core/issue/db/IssueDao.java
@@ -96,13 +96,13 @@ public class IssueDao implements BatchComponent, ServerComponent {
     return selectIssueAndProjectIds(query, authorizedRootProjectIds, query.maxResults(), session);
   }
 
-  private List<IssueDto> selectIssueAndProjectIds(IssueQuery query, Collection<Integer> authorizedRootProjectIds, Integer maxResult, SqlSession session){
+  private List<IssueDto> selectIssueAndProjectIds(IssueQuery query, Collection<Integer> authorizedRootProjectIds, Integer maxResults, SqlSession session){
     if (authorizedRootProjectIds.isEmpty()) {
       return Collections.emptyList();
     }
     IssueMapper mapper = session.getMapper(IssueMapper.class);
     List<List<Integer>> idsPartition = Lists.partition(newArrayList(authorizedRootProjectIds), 1000);
-    return mapper.selectIssueAndProjectIds(query, idsPartition, maxResult);
+    return mapper.selectIssueAndProjectIds(query, idsPartition, maxResults);
   }
 
   @VisibleForTesting
diff --git a/sonar-core/src/main/resources/org/sonar/core/issue/db/IssueMapper.xml b/sonar-core/src/main/resources/org/sonar/core/issue/db/IssueMapper.xml
index 08509871f2f..caa04f88709 100644
--- a/sonar-core/src/main/resources/org/sonar/core/issue/db/IssueMapper.xml
+++ b/sonar-core/src/main/resources/org/sonar/core/issue/db/IssueMapper.xml
@@ -147,7 +147,11 @@
   </select>
 
   <select id="selectIssueAndProjectIds" parameterType="map" resultType="Issue" fetchSize="2147483647">
-    select i.id, i.project_id as projectId
+    select
+    <if test="_databaseId == 'mssql' ">
+      top #{maxResults}
+    </if>
+    i.id, i.project_id as projectId
     <include refid="sortColumn"/>
     <include refid="selectQueryConditions"/>
   </select>
@@ -271,9 +275,14 @@
       <if test="query.createdBefore() != null">
         and i.issue_creation_date &lt; #{query.createdBefore}
       </if>
+      <if test="_databaseId == 'oracle' ">
+        and rownum &lt;= #{maxResults}
+      </if>
     </where>
     order by i.id
-    limit #{maxResults}
+    <if test="_databaseId != 'oracle' and _databaseId != 'mssql'">
+      limit #{maxResults}
+    </if>
   </sql>
 
 </mapper>
-- 
2.39.5