From 54ea81122399d74ad0f3939bad454188f5e9294d Mon Sep 17 00:00:00 2001
From: David Cho-Lerat <david.cho-lerat@sonarsource.com>
Date: Tue, 21 Nov 2023 11:29:56 +0100
Subject: [PATCH] SONAR-21017 Tests: 'exact' has been removed from options for
 'byRole' queries

---
 server/sonar-web/src/main/js/apps/code/__tests__/Code-it.ts   | 4 ++--
 .../src/main/js/apps/issues/__tests__/IssuesApp-it.tsx        | 4 +---
 server/sonar-web/src/main/js/apps/issues/test-utils.tsx       | 2 +-
 .../main/js/apps/sessions/components/__tests__/Login-it.tsx   | 4 +---
 4 files changed, 5 insertions(+), 9 deletions(-)

diff --git a/server/sonar-web/src/main/js/apps/code/__tests__/Code-it.ts b/server/sonar-web/src/main/js/apps/code/__tests__/Code-it.ts
index 726cd47a676..11b351f57d0 100644
--- a/server/sonar-web/src/main/js/apps/code/__tests__/Code-it.ts
+++ b/server/sonar-web/src/main/js/apps/code/__tests__/Code-it.ts
@@ -388,8 +388,8 @@ it('should correctly show new VS overall measures for Portfolios', async () => {
 function getPageObject(user: UserEvent) {
   const ui = {
     componentName: (name: string) => byText(name),
-    childComponent: (name: string | RegExp) => byRole('cell', { name, exact: false }),
-    searchResult: (name: string | RegExp) => byRole('link', { name, exact: false }),
+    childComponent: (name: string | RegExp) => byRole('cell', { name }),
+    searchResult: (name: string | RegExp) => byRole('link', { name }),
     componentIsEmptyTxt: (qualifier: ComponentQualifier) =>
       byText(`code_viewer.no_source_code_displayed_due_to_empty_analysis.${qualifier}`),
     searchInput: byRole('searchbox'),
diff --git a/server/sonar-web/src/main/js/apps/issues/__tests__/IssuesApp-it.tsx b/server/sonar-web/src/main/js/apps/issues/__tests__/IssuesApp-it.tsx
index 6c4457bbeae..e7a7d8d8611 100644
--- a/server/sonar-web/src/main/js/apps/issues/__tests__/IssuesApp-it.tsx
+++ b/server/sonar-web/src/main/js/apps/issues/__tests__/IssuesApp-it.tsx
@@ -203,9 +203,7 @@ describe('issues app', () => {
       expect(screen.getByRole('link', { name: 'simpleRuleId' })).toBeInTheDocument();
 
       // The "Where is the issue" tab should be selected by default. Check its content
-      expect(screen.getAllByRole('button', { name: 'Issue on file', exact: false })).toHaveLength(
-        2,
-      ); // there will be 2 buttons one in concise issue and other in code viewer
+      expect(screen.getAllByRole('button', { name: 'Issue on file' })).toHaveLength(2); // there will be 2 buttons one in concise issue and other in code viewer
       expect(
         screen.getByRole('row', {
           name: '2 * SonarQube',
diff --git a/server/sonar-web/src/main/js/apps/issues/test-utils.tsx b/server/sonar-web/src/main/js/apps/issues/test-utils.tsx
index 4ac409fb53d..a69dccf38db 100644
--- a/server/sonar-web/src/main/js/apps/issues/test-utils.tsx
+++ b/server/sonar-web/src/main/js/apps/issues/test-utils.tsx
@@ -64,7 +64,7 @@ export const ui = {
   issueItem7: byRole('region', { name: 'Issue with tags' }),
   issueItem8: byRole('region', { name: 'Issue on page 2' }),
   issueItem9: byRole('region', { name: 'Issue inside folderA' }),
-  projectIssueItem6: byRole('button', { name: 'Second issue', exact: false }),
+  projectIssueItem6: byRole('button', { name: 'Second issue' }),
 
   conciseIssueTotal: byTestId('page-counter-total'),
   conciseIssueItem2: byTestId('issues-nav-bar').byRole('button', { name: 'Fix that' }),
diff --git a/server/sonar-web/src/main/js/apps/sessions/components/__tests__/Login-it.tsx b/server/sonar-web/src/main/js/apps/sessions/components/__tests__/Login-it.tsx
index 7864492228b..be83dcf8968 100644
--- a/server/sonar-web/src/main/js/apps/sessions/components/__tests__/Login-it.tsx
+++ b/server/sonar-web/src/main/js/apps/sessions/components/__tests__/Login-it.tsx
@@ -125,9 +125,7 @@ it('should not show any OAuth providers if none are configured', async () => {
   expect(heading).toBeInTheDocument();
 
   // No OAuth providers, login form display by default.
-  expect(
-    screen.queryByRole('link', { name: 'login.login_with_x', exact: false }),
-  ).not.toBeInTheDocument();
+  expect(screen.queryByRole('link', { name: 'login.login_with_x' })).not.toBeInTheDocument();
   expect(screen.getByLabelText('login')).toBeInTheDocument();
 });
 
-- 
2.39.5