From 591d0eae799968578f1fd0d5e3b37a5ee8515d4a Mon Sep 17 00:00:00 2001 From: Toshi MARUYAMA Date: Tue, 24 Sep 2019 15:56:51 +0000 Subject: [PATCH] code cleanup: rubocop: fix Style/ZeroLengthPredicate in app/models/issue.rb git-svn-id: http://svn.redmine.org/redmine/trunk@18523 e93f8b46-1217-0410-a6f0-8f06a7374b81 --- .rubocop_todo.yml | 1 - app/models/issue.rb | 2 +- 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml index 9afd19ed3..d9971b00c 100644 --- a/.rubocop_todo.yml +++ b/.rubocop_todo.yml @@ -1726,7 +1726,6 @@ Style/WordArray: Style/ZeroLengthPredicate: Exclude: - 'app/models/import.rb' - - 'app/models/issue.rb' - 'app/models/mail_handler.rb' - 'app/models/user.rb' - 'lib/redmine/field_format.rb' diff --git a/app/models/issue.rb b/app/models/issue.rb index 6bfdaa433..8f74ec44e 100644 --- a/app/models/issue.rb +++ b/app/models/issue.rb @@ -77,7 +77,7 @@ class Issue < ActiveRecord::Base } scope :open, lambda {|*args| - is_closed = args.size > 0 ? !args.first : false + is_closed = !args.empty? ? !args.first : false joins(:status). where(:issue_statuses => {:is_closed => is_closed}) } -- 2.39.5