From 5a10161b58dfffdbbb80a2b60fe35d1ea8559aba Mon Sep 17 00:00:00 2001
From: Javen O'Neal <onealj@apache.org>
Date: Wed, 1 Feb 2017 00:59:20 +0000
Subject: [PATCH] release-prep1 should abort if release tag already exists.
 It's likely that the version was entered incorrectly or copy-pasted from a
 template.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1781191 13f79535-47bb-0310-9956-ffa450edef68
---
 build.xml | 20 +++++++++++++++++++-
 1 file changed, 19 insertions(+), 1 deletion(-)

diff --git a/build.xml b/build.xml
index 84d50fbf25..b07f253077 100644
--- a/build.xml
+++ b/build.xml
@@ -2441,8 +2441,26 @@ under the License.
         />
     </target>
 
+    <target name="release-prep0" depends="-init-svn" description="check to make sure the release tag doesn't exist yet">
+        <!-- verify that svn username/password are valid ... -->
+        <fail message="Unable to connect to SVN repo. Verify apache-id username and password.">
+            <condition>
+                <!-- FIXME: svnExists doesn't work with https here. -->
+                <not><svnExists refid="svn.settings" target="http://svn.apache.org/repos/asf/poi/"/></not>
+            </condition>
+        </fail>
+
+        <!-- verify that the release tag that we're about to create in release-prep1 does not already exist (no overwriting tags!) -->
+        <fail message="Cannot create release tag. https://svn.apache.org/repos/asf/poi/tags/${RELEASE_TAG} already exists. Verify the requested release version.">
+            <condition>
+                <!-- FIXME: svnExists doesn't work with https here. -->
+                <svnExists refid="svn.settings" target="http://svn.apache.org/repos/asf/poi/tags/${RELEASE_TAG}/"/>
+            </condition>
+        </fail>
+    </target>
+
     <!-- experimental release preparation ... tbd. ... -->
-    <target name="release-prep1" depends="-init-svn" description="update the documentation and create the svn tag - needs Java7+">
+    <target name="release-prep1" depends="-init-svn,release-prep0" description="update the documentation and create the svn tag - needs Java7+">
         <local name="tstamp_rel"/>
         <local name="tstamp_next"/>
         <local name="rel_next"/>
-- 
2.39.5