From 5b0b1b77dbc41c144959ef2fe8de603555beb39b Mon Sep 17 00:00:00 2001 From: Aditya Raghavan Date: Sat, 20 Dec 2014 18:41:24 -0500 Subject: [PATCH] Event: Normalize mouse event properties in drag events DragEvent is a superset of MouseEvent, so we want to fix up mouse properties like pageX and pageY. Fixes gh-1925 (cherry picked from commit 389b2ab3b93bfd68ca6c6153a43e11d93ab9ec71) --- src/event.js | 2 +- test/unit/event.js | 19 +++++++++++++++++++ 2 files changed, 20 insertions(+), 1 deletion(-) diff --git a/src/event.js b/src/event.js index b3a149891..1798df954 100644 --- a/src/event.js +++ b/src/event.js @@ -12,7 +12,7 @@ define([ var rformElems = /^(?:input|select|textarea)$/i, rkeyEvent = /^key/, - rmouseEvent = /^(?:mouse|pointer|contextmenu)|click/, + rmouseEvent = /^(?:mouse|pointer|contextmenu|drag)|click/, rfocusMorph = /^(?:focusinfocus|focusoutblur)$/, rtypenamespace = /^([^.]*)(?:\.(.+)|)/; diff --git a/test/unit/event.js b/test/unit/event.js index c772ef44c..8992a0b95 100644 --- a/test/unit/event.js +++ b/test/unit/event.js @@ -2477,6 +2477,25 @@ test("fixHooks extensions", function() { jQuery.event.fixHooks.click = saved; }); +// IE8 doesn't support custom event triggering natively, but we can skip +// this test in IE8 since a native HTML5 drag event will never occur there. +if ( document.createEvent ) { + + test( "drag events copy over mouse related event properties (gh-1925)", function() { + expect( 2 ); + + var $fixture = jQuery( "
" ).appendTo( "body" ); + + $fixture.on( "dragmove", function( evt ) { + ok( "pageX" in evt, "checking for pageX property" ); + ok( "pageY" in evt, "checking for pageY property" ); + }); + + fireNative( $fixture[ 0 ], "dragmove" ); + $fixture.unbind( "dragmove" ).remove(); + }); +} + test( "focusin using non-element targets", function() { expect( 2 ); -- 2.39.5