From 5b0e4a8e2d6e5c802673f622fa0a838218d95f16 Mon Sep 17 00:00:00 2001
From: Go MAEDA <maeda@farend.jp>
Date: Sat, 1 Oct 2022 06:54:27 +0000
Subject: [PATCH] Add table header in Plugins page (#37692).

Patch by Go MAEDA.


git-svn-id: https://svn.redmine.org/redmine/trunk@21879 e93f8b46-1217-0410-a6f0-8f06a7374b81
---
 app/views/admin/plugins.html.erb         | 8 ++++++++
 test/functional/admin_controller_test.rb | 4 ++++
 2 files changed, 12 insertions(+)

diff --git a/app/views/admin/plugins.html.erb b/app/views/admin/plugins.html.erb
index 3d88c90d0..c2d9f7b0d 100644
--- a/app/views/admin/plugins.html.erb
+++ b/app/views/admin/plugins.html.erb
@@ -3,6 +3,13 @@
 <% if @plugins.any? %>
 <div class="autoscroll">
   <table class="list plugins">
+      <thead><tr>
+        <th><%= l(:field_name) %> / <%= l(:field_description) %></th>
+        <th><%= l(:field_author) %></th>
+        <th><%= l(:label_version) %></th>
+        <th></th>
+      </tr></thead>
+      <tbody>
       <% @plugins.each do |plugin| %>
           <tr id="plugin-<%= plugin.id %>">
           <td class="name"><span class="name"><%= plugin.name %></span>
@@ -14,6 +21,7 @@
           <td class="configure"><%= link_to(l(:button_configure), plugin_settings_path(plugin)) if plugin.configurable? %></td>
           </tr>
       <% end %>
+      </tbody>
   </table>
 </div>
 <p><a href="#" id="check-for-updates"><%= l(:label_check_for_updates) %></a></p>
diff --git a/test/functional/admin_controller_test.rb b/test/functional/admin_controller_test.rb
index 9cebf8ca7..d9b13bc5e 100644
--- a/test/functional/admin_controller_test.rb
+++ b/test/functional/admin_controller_test.rb
@@ -156,6 +156,10 @@ class AdminControllerTest < Redmine::ControllerTest
     get :plugins
     assert_response :success
 
+    assert_select 'th:nth-of-type(1)', :text => 'Name / Description'
+    assert_select 'th:nth-of-type(2)', :text => 'Author'
+    assert_select 'th:nth-of-type(3)', :text => 'Version'
+
     assert_select 'tr#plugin-foo' do
       assert_select 'td span.name', :text => 'Foo plugin'
       assert_select 'td.configure a[href="/settings/plugin/foo"]'
-- 
2.39.5