From 5caae9b3367cdad3c31d2ed8a7031efd8dfe71c3 Mon Sep 17 00:00:00 2001
From: =?utf8?q?Gr=C3=A9goire=20Aubert?= <gregoire.aubert@sonarsource.com>
Date: Tue, 13 Feb 2018 12:49:14 +0100
Subject: [PATCH] SONAR-10417 Remove domain description in sidebar of web api
 page

---
 .../js/app/styles/components/list-groups.css  |  8 ++-
 .../main/js/apps/web-api/components/Menu.tsx  |  8 +--
 .../__snapshots__/Menu-test.tsx.snap          | 72 -------------------
 3 files changed, 8 insertions(+), 80 deletions(-)

diff --git a/server/sonar-web/src/main/js/app/styles/components/list-groups.css b/server/sonar-web/src/main/js/app/styles/components/list-groups.css
index ba87375db5b..b2200de0745 100644
--- a/server/sonar-web/src/main/js/app/styles/components/list-groups.css
+++ b/server/sonar-web/src/main/js/app/styles/components/list-groups.css
@@ -43,16 +43,22 @@
   background-color: var(--lightBlue);
 }
 
+.list-group-item:hover {
+  z-index: var(--aboveNormalZIndex);
+  border-color: var(--blue) !important;
+}
+
 .list-group-item + .list-group-item {
   border-top-color: var(--barBorderColor);
 }
 
 a.list-group-item {
   color: var(--baseFontColor);
+  transition: none;
 }
 
 .list-group-item-heading {
-  margin-top: 0;
+  margin-top: 5px;
   margin-bottom: 5px;
 }
 
diff --git a/server/sonar-web/src/main/js/apps/web-api/components/Menu.tsx b/server/sonar-web/src/main/js/apps/web-api/components/Menu.tsx
index 7dd701ade21..334979d242c 100644
--- a/server/sonar-web/src/main/js/apps/web-api/components/Menu.tsx
+++ b/server/sonar-web/src/main/js/apps/web-api/components/Menu.tsx
@@ -49,22 +49,16 @@ export default function Menu(props: Props) {
       <div className="list-group">
         {filteredDomains.map(domain => (
           <Link
-            key={domain.path}
             className={classNames('list-group-item', {
               active: isDomainPathActive(domain.path, splat)
             })}
+            key={domain.path}
             to={'/web_api/' + domain.path}>
             <h3 className="list-group-item-heading">
               {domain.path}
               {domain.deprecated && <DeprecatedBadge />}
               {domain.internal && <InternalBadge />}
             </h3>
-            {domain.description && (
-              <div
-                className="list-group-item-text markdown"
-                dangerouslySetInnerHTML={{ __html: domain.description }}
-              />
-            )}
           </Link>
         ))}
       </div>
diff --git a/server/sonar-web/src/main/js/apps/web-api/components/__tests__/__snapshots__/Menu-test.tsx.snap b/server/sonar-web/src/main/js/apps/web-api/components/__tests__/__snapshots__/Menu-test.tsx.snap
index 87783ec3cf9..57099cb0383 100644
--- a/server/sonar-web/src/main/js/apps/web-api/components/__tests__/__snapshots__/Menu-test.tsx.snap
+++ b/server/sonar-web/src/main/js/apps/web-api/components/__tests__/__snapshots__/Menu-test.tsx.snap
@@ -19,14 +19,6 @@ exports[`should also render domains with an actions description matching the que
       >
         bar
       </h3>
-      <div
-        className="list-group-item-text markdown"
-        dangerouslySetInnerHTML={
-          Object {
-            "__html": "API Bar",
-          }
-        }
-      />
     </Link>
     <Link
       className="list-group-item"
@@ -40,14 +32,6 @@ exports[`should also render domains with an actions description matching the que
       >
         baz
       </h3>
-      <div
-        className="list-group-item-text markdown"
-        dangerouslySetInnerHTML={
-          Object {
-            "__html": "API Baz",
-          }
-        }
-      />
     </Link>
   </div>
 </div>
@@ -72,14 +56,6 @@ exports[`should not render deprecated domains 1`] = `
       >
         foo
       </h3>
-      <div
-        className="list-group-item-text markdown"
-        dangerouslySetInnerHTML={
-          Object {
-            "__html": "API Foo",
-          }
-        }
-      />
     </Link>
   </div>
 </div>
@@ -104,14 +80,6 @@ exports[`should not render internal domains 1`] = `
       >
         foo
       </h3>
-      <div
-        className="list-group-item-text markdown"
-        dangerouslySetInnerHTML={
-          Object {
-            "__html": "API Foo",
-          }
-        }
-      />
     </Link>
   </div>
 </div>
@@ -136,14 +104,6 @@ exports[`should render deprecated domains 1`] = `
       >
         foo
       </h3>
-      <div
-        className="list-group-item-text markdown"
-        dangerouslySetInnerHTML={
-          Object {
-            "__html": "API Foo",
-          }
-        }
-      />
     </Link>
     <Link
       className="list-group-item"
@@ -157,14 +117,6 @@ exports[`should render deprecated domains 1`] = `
       >
         bar
       </h3>
-      <div
-        className="list-group-item-text markdown"
-        dangerouslySetInnerHTML={
-          Object {
-            "__html": "API Bar",
-          }
-        }
-      />
     </Link>
   </div>
 </div>
@@ -189,14 +141,6 @@ exports[`should render internal domains 1`] = `
       >
         foo
       </h3>
-      <div
-        className="list-group-item-text markdown"
-        dangerouslySetInnerHTML={
-          Object {
-            "__html": "API Foo",
-          }
-        }
-      />
     </Link>
     <Link
       className="list-group-item"
@@ -211,14 +155,6 @@ exports[`should render internal domains 1`] = `
         bar
         <InternalBadge />
       </h3>
-      <div
-        className="list-group-item-text markdown"
-        dangerouslySetInnerHTML={
-          Object {
-            "__html": "API Bar",
-          }
-        }
-      />
     </Link>
   </div>
 </div>
@@ -243,14 +179,6 @@ exports[`should render only domains with an action matching the query 1`] = `
       >
         foo
       </h3>
-      <div
-        className="list-group-item-text markdown"
-        dangerouslySetInnerHTML={
-          Object {
-            "__html": "API Foo",
-          }
-        }
-      />
     </Link>
   </div>
 </div>
-- 
2.39.5