From 63c8ed6ff56f63c66f953e01c1612993e6e02532 Mon Sep 17 00:00:00 2001
From: Kevin Silva <kevin.silva@sonarsource.com>
Date: Mon, 4 Dec 2023 20:09:08 +0100
Subject: [PATCH] SONAR-21068 Improve loading for Permission Template

---
 .../components/Template.tsx                   | 36 +++++++++++++------
 1 file changed, 26 insertions(+), 10 deletions(-)

diff --git a/server/sonar-web/src/main/js/apps/permission-templates/components/Template.tsx b/server/sonar-web/src/main/js/apps/permission-templates/components/Template.tsx
index 51a49681e57..58f4fde6206 100644
--- a/server/sonar-web/src/main/js/apps/permission-templates/components/Template.tsx
+++ b/server/sonar-web/src/main/js/apps/permission-templates/components/Template.tsx
@@ -163,6 +163,7 @@ export default class Template extends React.PureComponent<Props, State> {
 
     this.setState(({ users }) => ({
       users: this.addPermissionToEntity(users, login, permission),
+      loading: true,
     }));
 
     const request = isProjectCreator
@@ -173,11 +174,15 @@ export default class Template extends React.PureComponent<Props, State> {
           permission,
         });
 
-    return request.then(this.props.refresh).catch(() => {
-      this.setState(({ users }) => ({
-        users: this.removePermissionFromEntity(users, login, permission),
-      }));
-    });
+    return request
+      .then(this.props.refresh)
+      .then(() => this.setState({ loading: false }))
+      .catch(() => {
+        this.setState(({ users }) => ({
+          users: this.removePermissionFromEntity(users, login, permission),
+          loading: false,
+        }));
+      });
   };
 
   revokePermissionFromUser = (login: string, permission: string) => {
@@ -186,6 +191,7 @@ export default class Template extends React.PureComponent<Props, State> {
 
     this.setState(({ users }) => ({
       users: this.removePermissionFromEntity(users, login, permission),
+      loading: true,
     }));
 
     const request = isProjectCreator
@@ -196,11 +202,15 @@ export default class Template extends React.PureComponent<Props, State> {
           permission,
         });
 
-    return request.then(this.props.refresh).catch(() => {
-      this.setState(({ users }) => ({
-        users: this.addPermissionToEntity(users, login, permission),
-      }));
-    });
+    return request
+      .then(this.props.refresh)
+      .then(() => this.setState({ loading: false }))
+      .catch(() => {
+        this.setState(({ users }) => ({
+          users: this.addPermissionToEntity(users, login, permission),
+          loading: false,
+        }));
+      });
   };
 
   grantPermissionToGroup = (groupName: string, permission: string) => {
@@ -208,6 +218,7 @@ export default class Template extends React.PureComponent<Props, State> {
 
     this.setState(({ groups }) => ({
       groups: this.addPermissionToEntity(groups, groupName, permission),
+      loading: true,
     }));
 
     return api
@@ -217,9 +228,11 @@ export default class Template extends React.PureComponent<Props, State> {
         permission,
       })
       .then(this.props.refresh)
+      .then(() => this.setState({ loading: false }))
       .catch(() => {
         this.setState(({ groups }) => ({
           groups: this.removePermissionFromEntity(groups, groupName, permission),
+          loading: false,
         }));
       });
   };
@@ -229,6 +242,7 @@ export default class Template extends React.PureComponent<Props, State> {
 
     this.setState(({ groups }) => ({
       groups: this.removePermissionFromEntity(groups, groupName, permission),
+      loading: true,
     }));
 
     return api
@@ -238,9 +252,11 @@ export default class Template extends React.PureComponent<Props, State> {
         permission,
       })
       .then(this.props.refresh)
+      .then(() => this.setState({ loading: false }))
       .catch(() => {
         this.setState(({ groups }) => ({
           groups: this.addPermissionToEntity(groups, groupName, permission),
+          loading: false,
         }));
       });
   };
-- 
2.39.5