From 64829cd6db50b5b396c59e9c242aeaefe47a1f24 Mon Sep 17 00:00:00 2001 From: Simon Brandhof Date: Sat, 24 May 2014 09:17:37 +0200 Subject: [PATCH] SONAR-5007 fix test on postgres --- .../db/QualityProfileDaoTest.java | 44 +++++++++++-------- 1 file changed, 25 insertions(+), 19 deletions(-) diff --git a/sonar-core/src/test/java/org/sonar/core/qualityprofile/db/QualityProfileDaoTest.java b/sonar-core/src/test/java/org/sonar/core/qualityprofile/db/QualityProfileDaoTest.java index 304d31346c8..e62ce0abdce 100644 --- a/sonar-core/src/test/java/org/sonar/core/qualityprofile/db/QualityProfileDaoTest.java +++ b/sonar-core/src/test/java/org/sonar/core/qualityprofile/db/QualityProfileDaoTest.java @@ -23,6 +23,7 @@ package org.sonar.core.qualityprofile.db; import org.junit.Before; import org.junit.Test; import org.sonar.core.persistence.AbstractDaoTestCase; +import org.sonar.core.persistence.DbSession; import java.util.List; @@ -84,25 +85,30 @@ public class QualityProfileDaoTest extends AbstractDaoTestCase { public void select_all() { setupData("shared"); - List dtos = dao.findAll(getMyBatis().openSession(false)); - - assertThat(dtos).hasSize(2); - - QualityProfileDto dto1 = dtos.get(0); - assertThat(dto1.getId()).isEqualTo(1); - assertThat(dto1.getName()).isEqualTo("Sonar Way"); - assertThat(dto1.getLanguage()).isEqualTo("java"); - assertThat(dto1.getParent()).isNull(); - assertThat(dto1.getVersion()).isEqualTo(1); - assertThat(dto1.isUsed()).isFalse(); - - QualityProfileDto dto2 = dtos.get(1); - assertThat(dto2.getId()).isEqualTo(2); - assertThat(dto2.getName()).isEqualTo("Sonar Way"); - assertThat(dto2.getLanguage()).isEqualTo("js"); - assertThat(dto2.getParent()).isNull(); - assertThat(dto2.getVersion()).isEqualTo(1); - assertThat(dto2.isUsed()).isFalse(); + DbSession session = getMyBatis().openSession(false); + try { + List dtos = dao.findAll(session); + + assertThat(dtos).hasSize(2); + + QualityProfileDto dto1 = dtos.get(0); + assertThat(dto1.getId()).isEqualTo(1); + assertThat(dto1.getName()).isEqualTo("Sonar Way"); + assertThat(dto1.getLanguage()).isEqualTo("java"); + assertThat(dto1.getParent()).isNull(); + assertThat(dto1.getVersion()).isEqualTo(1); + assertThat(dto1.isUsed()).isFalse(); + + QualityProfileDto dto2 = dtos.get(1); + assertThat(dto2.getId()).isEqualTo(2); + assertThat(dto2.getName()).isEqualTo("Sonar Way"); + assertThat(dto2.getLanguage()).isEqualTo("js"); + assertThat(dto2.getParent()).isNull(); + assertThat(dto2.getVersion()).isEqualTo(1); + assertThat(dto2.isUsed()).isFalse(); + } finally { + session.close(); + } } @Test -- 2.39.5