From 67b1db14c964418ce8b1fd760d54761040cc32af Mon Sep 17 00:00:00 2001 From: =?utf8?q?Scott=20Gonz=C3=A1lez?= Date: Mon, 4 Oct 2010 09:15:40 -0400 Subject: [PATCH] Dialog: Don't change DOM position on open. Fixes #6137 - dialog('open') causes form elements to reset on IE7. --- tests/unit/dialog/dialog_tickets.js | 17 +++++++++++++++++ ui/jquery.ui.dialog.js | 3 --- 2 files changed, 17 insertions(+), 3 deletions(-) diff --git a/tests/unit/dialog/dialog_tickets.js b/tests/unit/dialog/dialog_tickets.js index dfa480fb7..f7b590b53 100644 --- a/tests/unit/dialog/dialog_tickets.js +++ b/tests/unit/dialog/dialog_tickets.js @@ -61,4 +61,21 @@ test("#5531: dialog width should be at least minWidth on creation", function () }); +test("#6137: dialog('open') causes form elements to reset on IE7", function() { + expect(2); + + d1 = $('
' + + 'b
').dialog({autoOpen: false}); + + d1.find('#b')[0].checked = true; + equal($('input:checked').val(), 'b', "checkbox b is checked"); + + d2 = $('
').dialog({autoOpen: false}); + + d1.dialog('open'); + equal($('input:checked').val(), 'b', "checkbox b is checked"); + + d1.add(d2).remove(); +}) + })(jQuery); diff --git a/ui/jquery.ui.dialog.js b/ui/jquery.ui.dialog.js index 86dfa5fa1..b000bf5bd 100644 --- a/ui/jquery.ui.dialog.js +++ b/ui/jquery.ui.dialog.js @@ -309,9 +309,6 @@ $.widget("ui.dialog", { uiDialog = self.uiDialog; self.overlay = options.modal ? new $.ui.dialog.overlay(self) : null; - if (uiDialog.next().length) { - uiDialog.appendTo('body'); - } self._size(); self._position(options.position); uiDialog.show(options.show); -- 2.39.5