From 6af2a9e23d6670dfd92e6d9948a920b5b70b2626 Mon Sep 17 00:00:00 2001 From: Simon Brandhof Date: Wed, 22 Apr 2015 18:58:51 +0200 Subject: [PATCH] Fix quality flaws --- .../java/org/sonar/core/util/DefaultHttpDownloader.java | 2 -- .../src/main/java/org/sonar/api/utils/HttpDownloader.java | 2 ++ .../java/org/sonar/api/utils/dag/DirectAcyclicGraph.java | 8 +++++--- 3 files changed, 7 insertions(+), 5 deletions(-) diff --git a/sonar-core/src/main/java/org/sonar/core/util/DefaultHttpDownloader.java b/sonar-core/src/main/java/org/sonar/core/util/DefaultHttpDownloader.java index d7a311a24c8..64a4a43942e 100644 --- a/sonar-core/src/main/java/org/sonar/core/util/DefaultHttpDownloader.java +++ b/sonar-core/src/main/java/org/sonar/core/util/DefaultHttpDownloader.java @@ -60,8 +60,6 @@ import java.util.zip.GZIPInputStream; * @since 2.2 */ public class DefaultHttpDownloader extends HttpDownloader { - public static final int TIMEOUT_MILLISECONDS = 20 * 1000; - private final BaseHttpDownloader downloader; private final Integer readTimeout; diff --git a/sonar-plugin-api/src/main/java/org/sonar/api/utils/HttpDownloader.java b/sonar-plugin-api/src/main/java/org/sonar/api/utils/HttpDownloader.java index 2c0ae79479c..4965f14d3d4 100644 --- a/sonar-plugin-api/src/main/java/org/sonar/api/utils/HttpDownloader.java +++ b/sonar-plugin-api/src/main/java/org/sonar/api/utils/HttpDownloader.java @@ -31,6 +31,8 @@ import java.net.URI; * a constructor parameter. It is available in both batch and server. */ public abstract class HttpDownloader extends UriReader.SchemeProcessor implements BatchComponent, ServerComponent { + public static final int TIMEOUT_MILLISECONDS = 20 * 1000; + public abstract String downloadPlainText(URI uri, String encoding); public abstract byte[] download(URI uri); diff --git a/sonar-plugin-api/src/main/java/org/sonar/api/utils/dag/DirectAcyclicGraph.java b/sonar-plugin-api/src/main/java/org/sonar/api/utils/dag/DirectAcyclicGraph.java index 6cd3b683af9..76595f08550 100644 --- a/sonar-plugin-api/src/main/java/org/sonar/api/utils/dag/DirectAcyclicGraph.java +++ b/sonar-plugin-api/src/main/java/org/sonar/api/utils/dag/DirectAcyclicGraph.java @@ -19,11 +19,13 @@ */ package org.sonar.api.utils.dag; -import com.google.common.collect.Lists; - import org.sonar.api.utils.SonarException; -import java.util.*; +import java.util.ArrayList; +import java.util.Collections; +import java.util.HashMap; +import java.util.List; +import java.util.Map; /** * http://en.wikipedia.org/wiki/Directed_acyclic_graph -- 2.39.5