From 6b0afdc9ca096cb9f582aadfe6c072d61eea2fa6 Mon Sep 17 00:00:00 2001 From: Go MAEDA Date: Sat, 29 Feb 2020 04:59:48 +0000 Subject: [PATCH] "Role" dropdown in Workflow page is unexpectedly expanded when selecting "all" (#33059). Patch by Mizuki ISHIKAWA. git-svn-id: http://svn.redmine.org/redmine/trunk@19538 e93f8b46-1217-0410-a6f0-8f06a7374b81 --- app/controllers/workflows_controller.rb | 2 +- test/functional/workflows_controller_test.rb | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/app/controllers/workflows_controller.rb b/app/controllers/workflows_controller.rb index 8aa438b06..f5bb9dec5 100644 --- a/app/controllers/workflows_controller.rb +++ b/app/controllers/workflows_controller.rb @@ -124,7 +124,7 @@ class WorkflowsController < ApplicationController def find_roles ids = Array.wrap(params[:role_id]) if ids == ['all'] - @roles = Role.sorted.to_a + @roles = Role.sorted.select(&:consider_workflow?) elsif ids.present? @roles = Role.where(:id => ids).to_a end diff --git a/test/functional/workflows_controller_test.rb b/test/functional/workflows_controller_test.rb index 51b3ec5d0..e1759ea03 100644 --- a/test/functional/workflows_controller_test.rb +++ b/test/functional/workflows_controller_test.rb @@ -97,8 +97,8 @@ class WorkflowsControllerTest < Redmine::ControllerTest get :edit, :params => {:role_id => 'all', :tracker_id => 'all'} assert_response :success - assert_select 'select[name=?][multiple=multiple]', 'role_id[]' do - assert_select 'option[selected=selected]', Role.all.count(&:consider_workflow?) + assert_select 'select[name=?]', 'role_id[]' do + assert_select 'option[selected=selected][value=all]' end assert_select 'select[name=?]', 'tracker_id[]' do assert_select 'option[selected=selected][value=all]' -- 2.39.5