From 6c80b0ffedebf950de66f93f18d5165097904088 Mon Sep 17 00:00:00 2001 From: Jacek Date: Tue, 9 Jun 2020 15:16:56 +0200 Subject: [PATCH] SONAR-13398 deprecate issue count fields in response for api/project_pull_requests/lists WS --- .../main/java/org/sonar/server/branch/pr/ws/ListAction.java | 6 ++++-- .../java/org/sonar/server/branch/pr/ws/ListActionTest.java | 5 +++++ 2 files changed, 9 insertions(+), 2 deletions(-) diff --git a/server/sonar-webserver-webapi/src/main/java/org/sonar/server/branch/pr/ws/ListAction.java b/server/sonar-webserver-webapi/src/main/java/org/sonar/server/branch/pr/ws/ListAction.java index 8acbd6e396f..c9d484de694 100644 --- a/server/sonar-webserver-webapi/src/main/java/org/sonar/server/branch/pr/ws/ListAction.java +++ b/server/sonar-webserver-webapi/src/main/java/org/sonar/server/branch/pr/ws/ListAction.java @@ -26,6 +26,7 @@ import java.util.Optional; import java.util.function.Function; import javax.annotation.Nullable; import org.apache.commons.lang.StringUtils; +import org.sonar.api.server.ws.Change; import org.sonar.api.server.ws.Request; import org.sonar.api.server.ws.Response; import org.sonar.api.server.ws.WebService; @@ -84,8 +85,9 @@ public class ListAction implements PullRequestWsAction { "
  • 'Execute Analysis' rights on the specified project
  • " + "") .setResponseExample(getClass().getResource("list-example.json")) - .setHandler(this); - + .setHandler(this) + .setChangelog( + new Change("8.4", "Response fields: 'bugs', 'vulnerabilities', 'codeSmells' are deprecated.")); addProjectParam(action); } diff --git a/server/sonar-webserver-webapi/src/test/java/org/sonar/server/branch/pr/ws/ListActionTest.java b/server/sonar-webserver-webapi/src/test/java/org/sonar/server/branch/pr/ws/ListActionTest.java index 0f81c264826..4d123a46de4 100644 --- a/server/sonar-webserver-webapi/src/test/java/org/sonar/server/branch/pr/ws/ListActionTest.java +++ b/server/sonar-webserver-webapi/src/test/java/org/sonar/server/branch/pr/ws/ListActionTest.java @@ -24,6 +24,7 @@ import org.junit.Rule; import org.junit.Test; import org.junit.rules.ExpectedException; import org.sonar.api.resources.ResourceTypes; +import org.sonar.api.server.ws.Change; import org.sonar.api.server.ws.WebService; import org.sonar.api.utils.DateUtils; import org.sonar.api.utils.System2; @@ -108,6 +109,10 @@ public class ListActionTest { assertThat(definition.isInternal()).isFalse(); assertThat(definition.params()).extracting(WebService.Param::key).containsExactlyInAnyOrder("project"); assertThat(definition.since()).isEqualTo("7.1"); + + assertThat(definition.changelog()) + .extracting(Change::getVersion, Change::getDescription) + .contains(tuple("8.4", "Response fields: 'bugs', 'vulnerabilities', 'codeSmells' are deprecated.")); } @Test -- 2.39.5