From 70847d620e569920694801fc3ca5fd56a5a60f49 Mon Sep 17 00:00:00 2001
From: Yegor Kozlov <yegor@apache.org>
Date: Tue, 30 Dec 2008 09:24:15 +0000
Subject: [PATCH] Fix for bug 46445 - move hyperlinks when shifting rows

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@730076 13f79535-47bb-0310-9956-ffa450edef68
---
 .../apache/poi/hssf/usermodel/HSSFSheet.java  |   6 +++
 .../org/apache/poi/hssf/data/46445.xls        | Bin 0 -> 17408 bytes
 .../apache/poi/hssf/usermodel/TestBugs.java   |  24 ++++++++++
 .../poi/hssf/usermodel/TestHSSFHyperlink.java |  45 ++++++++++++++++++
 4 files changed, 75 insertions(+)
 create mode 100755 src/testcases/org/apache/poi/hssf/data/46445.xls

diff --git a/src/java/org/apache/poi/hssf/usermodel/HSSFSheet.java b/src/java/org/apache/poi/hssf/usermodel/HSSFSheet.java
index ac84059467..9ed29e00f5 100644
--- a/src/java/org/apache/poi/hssf/usermodel/HSSFSheet.java
+++ b/src/java/org/apache/poi/hssf/usermodel/HSSFSheet.java
@@ -1187,6 +1187,12 @@ public final class HSSFSheet implements org.apache.poi.ss.usermodel.Sheet {
                 cellRecord.setRow( rowNum + n );
                 row2Replace.createCellFromRecord( cellRecord );
                 sheet.addValueRecord( rowNum + n, cellRecord );
+
+                HSSFHyperlink link = cell.getHyperlink();
+                if(link != null){
+                    link.setFirstRow(link.getFirstRow() + n);
+                    link.setLastRow(link.getLastRow() + n);
+                }
             }
             // Now zap all the cells in the source row
             row.removeAllCells();
diff --git a/src/testcases/org/apache/poi/hssf/data/46445.xls b/src/testcases/org/apache/poi/hssf/data/46445.xls
new file mode 100755
index 0000000000000000000000000000000000000000..30aaf343ada7a2893036f585dbe656849a08490f
GIT binary patch
literal 17408
zcmeHPU2I%O75?seH(uLu{GT{~o7;6z94E0-OKmKy);3A2xJjsSS{kU!;>MeLvE!}Q
z8%Pj{ZAm2_f>hKBULv7NEi_5hf{*}(3MFquqBKIPDi9Jb3NH}?fr`|iw&wfJ-Ru4F
zZg4{iN_5ZW%*;J=X3m*&=gysT?l_m<Y?*)I$Lrof8QhB+e7I1D6-9K1W!JxM2J06V
zbm`}tSSBfeTgU=+QQpWE5$tf^sJ(Q7#Twupgz%&AMW(=?h~sz?D}m1?pGaried({x
zq`!P+I^}+>@F~+_!jTRaIPvar!f;4CO<aYwrdz9}ZI-@foUdDY4_a}YzfA)VZSH4#
zu;ro9knw%n(zvCom^%2GwfVhK?!-F$iu?=Tcvh1gSQBxEkwFR*n8C+g>rn3N8gQtR
z+%WHfwBo-CT7|K>Vr?wE4H2}#>B4q&@wXFkyyC_&z}vcm*QL~0_%1&3ot4-h#Tb&9
z#A8(&?m{i^OOc#j%Bm)<xGokRMijB?O{+;R?IejFigOYiRS(=HBNN>lbM;!kZJfOE
zyq&yuN{65{7EWL*^9q6zG_1!i)0T=U)QLlNo{&<yFX9+)OMfL1#Y3(pYAH{t$UzKN
z9a|dPa94G~1#Op(&=XtWSSqx%&L8UryofbGd~>{Odso-a#MXiFZvSF@Yb<;RUc!cw
z`bWo-laG}$#qk4dEHL%%EbWKa>S_yq$dNCK^0>-+%d_sn%jg3VQl-cBHOpU)cN<}R
z>p-3m-w~(YiSD5UrS#$qX9$}Xx9f3>8}+y)Ee3HGpDY#T=~gPwR4WoWI9L#RH_mZ=
zDhT!4FUs{Bo9IHzd9>R?_s<2_axb~yiq4e=Mt|3@x;|Y?S0(;xboE+^|8}N3eDVw6
z+w+`fhxhy%pMIta{cIKb%N6Oh?Dk#l)XMIo_I8!%4(clQ6CuCpA7#P7(^LI?#&M0}
zC1vy?{^vqrH0Np-l(*zoSl*foTi%wdwY)u7XL(01YB_SSe046e@I^=O>}R+KsIQl-
z6*xGROlI#C<=5+qD1E1(9fN~cxpQEf@EX2kG@}KbSdTk6m<E>fw8jCeVX_eyohT8=
z^*eYU=lNoTVI44*{)#(sB%91|$=ZA3$z*0GH9PGdotR9zsaZF9{BUxn0~md9gqL&4
zOm@yShN)yGxgNMr^#zL8lRGz+I+9)MwOZt^P-jw%VKO<FP0dbZQ|Z~oUMtovpq|6t
zLB+X&!{KNL(H|#3O$|aarMDAoF4+k-guK;3T)O+Obpma)a-;2>Rx+JLla*VT0?icm
z{+Yl3_Q2z#g9)Se7=4?iPa7pi9v?ozS-{;Eo?^|#uw+T4ZyNVWOAp}Bjle<fzm8%K
z$1sa0;9@uS;}GAYeO&YI=1$KgN7D9bNpdX(PJ!?rP}^AZ$DE@%akV}jon&6ieWB*l
zp->Ie{p=&lpL)7^p!p@+RD;p6k<ZR^6MpkSk}E+qdL`a~cKcgE^TC@F-=)_dKwyDV
z3utk2kd9uhckpJ1y>_{q;EVXbfLmt`I?gxD%>!@Txm=DG&BqvSUgtqix26R&DJHnJ
z(dHwCUQ8p+ZOk;wM@d&+fQOAQMa~%u#}sOAm6Ap~$?c>UJTBMTi=CEJuXnADoIvYQ
z-;$r|=*X9W*TN@iOQ>G}fdv8!EXM-*cfTBCJ~pM9cfFimig{jOWX|Eb;5~^Ux@3Os
z{GeBwA9V0ApYkZaZr&`gxub~zfDp3L2Z%mD7)y@Pi{C&ee;q^8oeVForeoR8FnB9k
z=%h9=SkTBm8t5I@vA<gO5@EQYhJA53p;gwE9A5PWL_?l`7Ne_b;4~RcD@Hj@YM0Zr
zsV=9<@hzr(KwSh)wgvwshFEr}`HlWILOn{uCXNhtCEXa?&tFL^??Z|>#nVIt-llc_
z%6yao|5f(8H`I!s+Lyo~G2~%mURPeKOTpi0NMIN7=gtg`>D|N2m#&_;cK$alr=Dh<
zbKjW;Q5n&tDvY7v1ivoH<DTJbZk8`Q*Is&)q`5|MSvroxOlQb1BOSyPujH%uF^V&+
zxTn$oQv^eDzr}dT72^Lcf}x467>75p?{{Pg5(tHf-I<@*{?zmACad~WkKcx@4T`2-
zF|9CtbO#EzUX%E3PVqg=+j%qXR$5O(mU_u`Z>2Xci@1a0?PGxtIjtfUTsh6X`DecW
zk82N3HJ|%V6x+7^<aawsdy$x5?lHu&mW{nct-cQtTZwv36>dC9Wbh8p65EKUiJIA0
z*htH&+6q+G0y{jL&8GN)d2Tv&lpmNE=?7AWGwHeXk*sU+Q<ID5-&@;#{uj;=+W}Ag
zW%rjZIYI2gj1eS(1p*5M76>d5SRk-KV1d8_fdv8!1QrM^5LjS|1*-Y~^3y|az46xR
z-u2DTeUJYC_G_>1AuUoyYiFR~GU+^FWKqCT<_aSoBJzk71G-?C)r$$p$IlWK3-}sw
zHSr`-F@jS>#SG38E5!)p+c#}#u)bKVn#U+a?G>Z&PKFhVeOQ^VRm4GBJ(A8$&*}Ww
zoJC#LknlXwk0rP)D;CmERP_*1*D6cj#OTPL#NPcQpWb)SXo_tNlfIv*NSylFjV~<r
z=l82z^_z(5PgYU6T71)3f+Vm&V1d8_fdv8!1QrM^5Lh6vKwyEu0)Yhr3*4Xud|y`n
zC|y_kD<Ao#@}KohUw*xOQhCercjc?=c$EI;U;ey~vgn(?e0u-ycjVWrUgvxGXH7hW
z1s=un&iwF?H0`^->OUYV58(f2fiWI6PBSXw;yycAoZ)$_j{>WCdc@aWF%dVa6u4k1
z?)Ne;9ew3r`##Te8oK8`{Sivf@YL7irpL5TUUts^17K0U^jL1gEjoZki10MoF`hWn
zL2HeDgjP6WI*Fp=*lAL#LpSB?8PfB!T={m)P7e<u!joBPo^F#4NxK6dO`rZ77{B6j
JcHoBDzX7=P8VUda

literal 0
HcmV?d00001

diff --git a/src/testcases/org/apache/poi/hssf/usermodel/TestBugs.java b/src/testcases/org/apache/poi/hssf/usermodel/TestBugs.java
index 040d3cfae8..76c61dd35d 100644
--- a/src/testcases/org/apache/poi/hssf/usermodel/TestBugs.java
+++ b/src/testcases/org/apache/poi/hssf/usermodel/TestBugs.java
@@ -1642,4 +1642,28 @@ public final class TestBugs extends TestCase {
         assertEquals("\u0161\u017E\u010D\u0148\u0159", sheet.getRow(1).getCell(0).getStringCellValue());
     }
 
+    /**
+     * Multiple calls of HSSFWorkbook.write result in corrupted xls
+     */
+    public void test32191() throws IOException {
+        HSSFWorkbook wb = openSample("27394.xls");
+
+        ByteArrayOutputStream out = new ByteArrayOutputStream();
+        wb.write(out);
+        out.close();
+        int size1 = out.size();
+        
+        out = new ByteArrayOutputStream();
+        wb.write(out);
+        out.close();
+        int size2 = out.size();
+
+        assertEquals(size1, size2);
+        out = new ByteArrayOutputStream();
+        wb.write(out);
+        out.close();
+        int size3 = out.size();
+        assertEquals(size2, size3);
+
+    }
 }
diff --git a/src/testcases/org/apache/poi/hssf/usermodel/TestHSSFHyperlink.java b/src/testcases/org/apache/poi/hssf/usermodel/TestHSSFHyperlink.java
index e741166b00..09443427a3 100755
--- a/src/testcases/org/apache/poi/hssf/usermodel/TestHSSFHyperlink.java
+++ b/src/testcases/org/apache/poi/hssf/usermodel/TestHSSFHyperlink.java
@@ -184,4 +184,49 @@ public final class TestHSSFHyperlink extends TestCase {
         assertNotNull(link);
         assertEquals("http://poi.apache.org/hssf/", link.getAddress());
     }
+
+    /**
+     * Test that HSSFSheet#shiftRows moves hyperlinks,
+     * see bugs #46445 and #29957
+     */
+    public void testShiftRows(){
+        HSSFWorkbook wb = HSSFTestDataSamples.openSampleWorkbook("46445.xls");
+
+
+        HSSFSheet sheet = wb.getSheetAt(0);
+
+        //verify existing hyperlink in A3
+        HSSFCell cell1 = sheet.getRow(2).getCell(0);
+        HSSFHyperlink link1 = cell1.getHyperlink();
+        assertNotNull(link1);
+        assertEquals(2, link1.getFirstRow());
+        assertEquals(2, link1.getLastRow());
+
+        //assign a hyperlink to A4
+        HSSFHyperlink link2 = new HSSFHyperlink(HSSFHyperlink.LINK_DOCUMENT);
+        link2.setAddress("Sheet2!A2");
+        HSSFCell cell2 = sheet.getRow(3).getCell(0);
+        cell2.setHyperlink(link2);
+        assertEquals(3, link2.getFirstRow());
+        assertEquals(3, link2.getLastRow());
+
+        //move the 3rd row two rows down
+        sheet.shiftRows(sheet.getFirstRowNum(), sheet.getLastRowNum(), 2);
+
+        //cells A3 and A4 don't contain hyperlinks anymore
+        assertNull(sheet.getRow(2).getCell(0).getHyperlink());
+        assertNull(sheet.getRow(3).getCell(0).getHyperlink());
+
+        //the first hypelink now belongs to A5
+        HSSFHyperlink link1_shifted = sheet.getRow(2+2).getCell(0).getHyperlink();
+        assertNotNull(link1_shifted);
+        assertEquals(4, link1_shifted.getFirstRow());
+        assertEquals(4, link1_shifted.getLastRow());
+
+        //the second hypelink now belongs to A6
+        HSSFHyperlink link2_shifted = sheet.getRow(3+2).getCell(0).getHyperlink();
+        assertNotNull(link2_shifted);
+        assertEquals(5, link2_shifted.getFirstRow());
+        assertEquals(5, link2_shifted.getLastRow());
+    }
 }
-- 
2.39.5