From 716046af83ec05a44314a792648863646398d3b9 Mon Sep 17 00:00:00 2001 From: Juuso Valli Date: Wed, 23 Apr 2014 16:19:18 +0300 Subject: [PATCH] Clarify comments in Table.typeIsCompatible (#8168) Change-Id: Idc9b2e2052afe2b5586904c535674ec686bb4685 --- server/src/com/vaadin/ui/Table.java | 18 ++---------------- 1 file changed, 2 insertions(+), 16 deletions(-) diff --git a/server/src/com/vaadin/ui/Table.java b/server/src/com/vaadin/ui/Table.java index 00a7038afd..e23a1bf688 100644 --- a/server/src/com/vaadin/ui/Table.java +++ b/server/src/com/vaadin/ui/Table.java @@ -2775,22 +2775,8 @@ public class Table extends AbstractSelect implements Action.Container, */ private boolean typeIsCompatible(Class a, Class b) { // TODO Implement this check properly - // Map, Class> typemap = new HashMap, Class>(); - // typemap.put(byte.class, Byte.class); - // typemap.put(short.class, Short.class); - // typemap.put(int.class, Integer.class); - // typemap.put(long.class, Long.class); - // typemap.put(float.class, Float.class); - // typemap.put(double.class, Double.class); - // typemap.put(char.class, Character.class); - // typemap.put(boolean.class, Boolean.class); - // if (typemap.containsKey(a)) { - // a = typemap.get(a); - // } - // if (typemap.containsKey(b)) { - // b = typemap.get(b); - // } - // return a.isAssignableFrom(b); + // Basically we need to do a a.isAssignableFrom(b) + // with special considerations for primitive types. return true; } -- 2.39.5