From 71d3ec25d8fc48686b6fda228e42bc4bac6db00e Mon Sep 17 00:00:00 2001 From: Nick Burch Date: Fri, 11 Feb 2011 12:36:57 +0000 Subject: [PATCH] Fix bug #46664 - When creating HSSF Print Areas, ensure the named range is reference based not value based git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1069780 13f79535-47bb-0310-9956-ffa450edef68 --- src/documentation/content/xdocs/status.xml | 1 + src/java/org/apache/poi/hssf/usermodel/HSSFWorkbook.java | 2 +- src/testcases/org/apache/poi/hssf/usermodel/TestBugs.java | 3 --- 3 files changed, 2 insertions(+), 4 deletions(-) diff --git a/src/documentation/content/xdocs/status.xml b/src/documentation/content/xdocs/status.xml index 9d8639c9c0..ef158f1f93 100644 --- a/src/documentation/content/xdocs/status.xml +++ b/src/documentation/content/xdocs/status.xml @@ -34,6 +34,7 @@ + 46664 - When creating HSSF Print Areas, ensure the named range is reference based not value based 50756 - When formatting numbers based on their Cell Style, treat GENERAL the same as the more typical General fixed HSSFWorkbook.createCellStyle to throw exception if the maximum number of cell styles was exceeded 50539 - Better fix for html-style br tags (invalid XML) inside XSSF documents diff --git a/src/java/org/apache/poi/hssf/usermodel/HSSFWorkbook.java b/src/java/org/apache/poi/hssf/usermodel/HSSFWorkbook.java index 20b5712f18..53867ecf95 100644 --- a/src/java/org/apache/poi/hssf/usermodel/HSSFWorkbook.java +++ b/src/java/org/apache/poi/hssf/usermodel/HSSFWorkbook.java @@ -1389,7 +1389,7 @@ public final class HSSFWorkbook extends POIDocument implements org.apache.poi.ss sb.append("!"); sb.append(parts[i]); } - name.setNameDefinition(HSSFFormulaParser.parse(sb.toString(), this, FormulaType.CELL, sheetIndex)); + name.setNameDefinition(HSSFFormulaParser.parse(sb.toString(), this, FormulaType.NAMEDRANGE, sheetIndex)); } /** diff --git a/src/testcases/org/apache/poi/hssf/usermodel/TestBugs.java b/src/testcases/org/apache/poi/hssf/usermodel/TestBugs.java index 440f3a3953..ae54b4aaac 100644 --- a/src/testcases/org/apache/poi/hssf/usermodel/TestBugs.java +++ b/src/testcases/org/apache/poi/hssf/usermodel/TestBugs.java @@ -1650,10 +1650,7 @@ public final class TestBugs extends BaseTestBugzillaIssues { "new_sheet!$A$1:$C$1", ((Area3DPtg)nr.getNameDefinition()[0]).toFormulaString(HSSFEvaluationWorkbook.create(wb)) ); - // TODO - fix me to be Reference not Value! -if(1==2) { assertEquals('R', nr.getNameDefinition()[0].getRVAType()); -} } /** -- 2.39.5