From 722212eafd59fd049fae7884d19691ef4a57f443 Mon Sep 17 00:00:00 2001 From: =?utf8?q?Johannes=20Dahlstr=C3=B6m?= Date: Tue, 19 Jun 2012 20:45:56 +0300 Subject: [PATCH] Fixed regression: AbstractClickEventHandler.onMouseUp() should call shouldFireEvent() --- .../terminal/gwt/client/ui/AbstractClickEventHandler.java | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/com/vaadin/terminal/gwt/client/ui/AbstractClickEventHandler.java b/src/com/vaadin/terminal/gwt/client/ui/AbstractClickEventHandler.java index 8ca700700c..e0ca798682 100644 --- a/src/com/vaadin/terminal/gwt/client/ui/AbstractClickEventHandler.java +++ b/src/com/vaadin/terminal/gwt/client/ui/AbstractClickEventHandler.java @@ -173,7 +173,8 @@ public abstract class AbstractClickEventHandler implements MouseDownHandler, if (hasEventListener() && mouseUpPreviewMatched && lastMouseDownTarget != null - && Util.getElementUnderMouse(event.getNativeEvent()) == lastMouseDownTarget) { + && Util.getElementUnderMouse(event.getNativeEvent()) == lastMouseDownTarget + && shouldFireEvent(event)) { // "Click" with left, right or middle button fireClick(event.getNativeEvent()); } -- 2.39.5